Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #429: State Card Image Center #436

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 20, 2019

Explanation

This PR, mainly makes the image of start-card (rich-text) center.

Screenshot_1574226398
Screenshot_1574226419

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the quick fix!

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Nov 20, 2019
@rt4914 rt4914 merged commit 9bd970e into develop Nov 20, 2019
@rt4914 rt4914 deleted the state-card-image-center branch November 20, 2019 06:05
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Nov 26, 2019
@nikitamarysolomanpvt
Copy link
Contributor

@rt4914 some times the image is showing at left side... Seems like image takes more time to load and if you open the pages and close the pages and go back again then this issue was noticed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants