-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4191: Added dark mode support to DeveloperOptionsActivity, ViewEventsLogsActivity and ForceNetworkTypeActivity #4308
Fixes #4191: Added dark mode support to DeveloperOptionsActivity, ViewEventsLogsActivity and ForceNetworkTypeActivity #4308
Conversation
…d ForceNetworkTypeActivity
@rt4914 @BenHenning @ayush0402 PTAL, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Akshatkamboj14! I mainly had 1 comment in code, and one other question: shouldn't we also be updating the math expressions developer options view? It seems a bit odd to update everything except that, or is there a separate tracking issue for it?
Otherwise, PTAL.
@ayush0402 PTAL as well since this is a dark mode PR.
app/src/main/res/layout/view_event_logs_event_log_item_view.xml
Outdated
Show resolved
Hide resolved
… Add-dark-mode-support-to-DevloperOptionsActivity-ViewEventsLogsActivity-and-ForceNetworkTypeActivity
@BenHenning There is no tracking issue for math expressions developer options currently as this was added later. |
@ayush0402 actually I am not getting what Math Expressions/Equations mean in this issue. |
Hey, @BenHenning @ayush0402 can you tell me from where can I take reference to implement dark mode on |
Sorry, I missed this earlier. @Akshatkamboj14 you can see the math & expressions screen by opening the developer options menu & scrolling to the bottom. In terms of mocks, you can follow the same styling as the other screens in developer options. Since these are developer-facing screens, it's less important to have perfect mocks. Feel free to ask if you're unsure about any particular parts of the screen though. The reason I'm suggesting this is that I'm treating #4191 as introducing dark mode support for all of developer options--is that wrong @ayush0402? |
… Add-dark-mode-support-to-DevloperOptionsActivity-ViewEventsLogsActivity-and-ForceNetworkTypeActivity
hey, @rt4914 @ayush0402 @BenHenning I have committed the changes, PTAL. |
…ctivity-ViewEventsLogsActivity-and-ForceNetworkTypeActivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Assigning @BenHenning for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks
Unassigning @aayushimathur6 since they have already approved the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor change. PTAL Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ctivity-ViewEventsLogsActivity-and-ForceNetworkTypeActivity
…ctivity-ViewEventsLogsActivity-and-ForceNetworkTypeActivity
Apologies for the super long delay here. Since my original requests have been addressed, my codeowners is no longer needed, all open threads seem resolved, and all other reviewers seem happy with the PR, I'm going ahead and merging this. Thanks @Akshatkamboj14! |
Explanation
Fixes: #4191
Mocks-
View Events Logs Activity:- https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/f23e514d-6f03-412e-883d-09817a43ce1f/specs/
Developer Options Activity:- https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/1ade83cc-ed11-4861-bf2a-60089232fd44/specs/
Force Network Type Activity:- https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/79be23a6-c676-4266-9f6c-60ac8751c68a/specs/
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: