Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Styles xml Fixes #3809 #3941

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fix Styles xml Fixes #3809 #3941

merged 1 commit into from
Oct 19, 2021

Conversation

bkaur-bkj
Copy link
Contributor

@bkaur-bkj bkaur-bkj commented Oct 16, 2021 •
edited
Loading

Explanation

Fixes #3809 made styles.xml file RTL compatible and removed it from exempted files list

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI check
below is screenshot of add profile xml after change where the StateButtonActive style is being used which I edited in styles.xml
WhatsApp Image 2021-10-16 at 7 54 41 PM

@bkaur-bkj
Copy link
Contributor Author

@rt4914 PTAL

rt4914
rt4914 approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Oct 18, 2021
BenHenning
BenHenning approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks @bkaur-bkj!

@BenHenning BenHenning merged commit 77d6ac9 into oppia:develop Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL Exempted file] Fix styles.xml
3 participants
@bkaur-bkj @rt4914 @BenHenning