Fix #359: Add descriptions for fractions & ratios topics #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitamurthi
approved these changes
Nov 19, 2019
Conflicts: app/src/main/java/org/oppia/app/topic/overview/TopicOverviewViewModel.kt app/src/sharedTest/java/org/oppia/app/topic/overview/TopicOverviewFragmentTest.kt
|
Thanks! I added two new tests, and fixed an existing test that I likely broke in one of my recent PR merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #359.
This adds descriptions for the fractions & ratios lessons, and updates our topic description parsing to support HTML.
This change includes a new test which has been verified to pass on Espresso. It does not run on Robolectric due to the legacy looper having issues. Unfortunately, since we share code between Espresso and Robolectric we can't properly annotated the class for Robolectric (since it puts a dependency on Robolectric when running the tests in an Espresso context).
This change also fixes a small issue in TopicActivity where it wasn't properly checking for topic ID to be present. Miscellaneous other fix-ups, including using the child fragment manager for the view pager.