Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RunAllTests] Add missing build flag to bazelrc #3936

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Oct 16, 2021

Explanation

This was an oversight on my part, but the androidx flag is necessary for building.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A

@BenHenning BenHenning marked this pull request as ready for review October 16, 2021 06:36
@BenHenning BenHenning closed this Oct 16, 2021
@BenHenning BenHenning changed the title Add missing build flag to bazelrc [RunAllTests] Add missing build flag to bazelrc Oct 16, 2021
@BenHenning BenHenning reopened this Oct 16, 2021
@oppiabot oppiabot bot unassigned seanlip Oct 16, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 16, 2021

Unassigning @seanlip since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Oct 16, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 16, 2021

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning
Copy link
Member Author

Merging since CI is passing.

@BenHenning BenHenning merged commit 4e19d2f into develop Oct 16, 2021
@BenHenning BenHenning deleted the add-missing-build-flag-to-bazelrc branch October 16, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants