-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3574 solution summary xml merged #3917
Conversation
@rt4914 bro can u please review my PR, if any changes required I'm ready for that. |
@bkaur-bkj Can you please review this PR first? |
@MohitGupta121 kindly complete the checklist and mark [x] at each point after you have acknowledged that part |
yes sir done |
@MohitGupta121 you need to commit changes only which are done by you not the idea/misc and other such files, pls revert back that changes |
Okayy, I'll do that |
@bkaur-bkj okay I try to resolve the commit but don't know why my local repo not update. |
@rt4914 @bkaur-bkj sorry accidentally I click on unassign can you please reassign me. |
done |
Yes, thanks |
This reverts commit d3638f1.
Updating Upstream Branch
@bkaur-bkj or @rt4914 Can you please review it, I resolved all the conflict and commit only my files changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Great work.
Unassigning @rt4914 since they have already approved the PR. |
Assigning @BenHenning for code owner reviews. Thanks! |
@rt4914 Thanks You. |
Yes by the time the PR gets approved and merged u can request to work on other issue |
Fix Issue : #3574
Essential Checklist
Before mobile-portrait and Landscape:-
After Mobile-Portrait and Landscape:-
Before Tab-Portrait and Landscape:-
After Tab-Portrait and Landscape:-
I'm use online emulator apkonline.net for testing Tablet layout. Because I try with android studio emulator but its too slow and very hang in my laptop that's why.