Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3574 solution summary xml merged #3917

Merged
merged 4 commits into from
Oct 16, 2021
Merged

Fix #3574 solution summary xml merged #3917

merged 4 commits into from
Oct 16, 2021

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Oct 9, 2021

Fix Issue : #3574

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before mobile-portrait and Landscape:-

image

image

After Mobile-Portrait and Landscape:-

image

image

Before Tab-Portrait and Landscape:-

image

image

After Tab-Portrait and Landscape:-

image

image

I'm use online emulator apkonline.net for testing Tablet layout. Because I try with android studio emulator but its too slow and very hang in my laptop that's why.

@rt4914 rt4914 self-assigned this Oct 9, 2021
@MohitGupta121
Copy link
Member Author

@rt4914 bro can u please review my PR, if any changes required I'm ready for that.

@rt4914
Copy link
Contributor

rt4914 commented Oct 14, 2021

@bkaur-bkj Can you please review this PR first?

@bkaur-bkj
Copy link
Contributor

Issue : #3574

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before mobile-portrait and Landscape:-

image

image

After Mobile-Portrait and Landscape:-

image

image

Before Tab-Portrait and Landscape:-

image

image

After Tab-Portrait and Landscape:-

image

image

I'm use online emulator apkonline.net for testing Tablet layout. Because I try with android studio emulator but its too slow and very hang in my laptop that's why.

@MohitGupta121 kindly complete the checklist and mark [x] at each point after you have acknowledged that part
also your PR has some merge conflicts due to some recent merged PR so update your branch from develop and resolve them locally and then make a commit again

@bkaur-bkj
Copy link
Contributor

@bkaur-bkj Can you please review this PR first?

yes sir done

@bkaur-bkj
Copy link
Contributor

@MohitGupta121 you need to commit changes only which are done by you not the idea/misc and other such files, pls revert back that changes

@MohitGupta121
Copy link
Member Author

@MohitGupta121 you need to commit changes only which are done by you not the idea/misc and other such files, pls revert back that changes

Okayy, I'll do that

@bkaur-bkj bkaur-bkj assigned MohitGupta121 and unassigned bkaur-bkj Oct 15, 2021
@MohitGupta121
Copy link
Member Author

Issue : #3574

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

Before mobile-portrait and Landscape:-
image
image
After Mobile-Portrait and Landscape:-
image
image
Before Tab-Portrait and Landscape:-
image
image
After Tab-Portrait and Landscape:-
image
image
I'm use online emulator apkonline.net for testing Tablet layout. Because I try with android studio emulator but its too slow and very hang in my laptop that's why.

@MohitGupta121 kindly complete the checklist and mark [x] at each point after you have acknowledged that part also your PR has some merge conflicts due to some recent merged PR so update your branch from develop and resolve them locally and then make a commit again

@bkaur-bkj okay I try to resolve the commit but don't know why my local repo not update.
I'll try it again.

@MohitGupta121 MohitGupta121 removed their assignment Oct 15, 2021
@MohitGupta121
Copy link
Member Author

@rt4914 @bkaur-bkj sorry accidentally I click on unassign can you please reassign me.

@bkaur-bkj
Copy link
Contributor

@rt4914 @bkaur-bkj sorry accidentally I click on unassign can you please reassign me.

done

@MohitGupta121
Copy link
Member Author

@rt4914 @bkaur-bkj sorry accidentally I click on unassign can you please reassign me.

done

Yes, thanks

@MohitGupta121 MohitGupta121 changed the title solution summary xml merged Fix #3574 solution summary xml merged Oct 15, 2021
@MohitGupta121
Copy link
Member Author

@MohitGupta121 you need to commit changes only which are done by you not the idea/misc and other such files, pls revert back that changes

@bkaur-bkj or @rt4914 Can you please review it, I resolved all the conflict and commit only my files changes.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Great work.

@rt4914 rt4914 enabled auto-merge (squash) October 16, 2021 10:57
@oppiabot oppiabot bot unassigned rt4914 Oct 16, 2021
@oppiabot
Copy link

oppiabot bot commented Oct 16, 2021

Unassigning @rt4914 since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Oct 16, 2021

Assigning @BenHenning for code owner reviews. Thanks!

@MohitGupta121
Copy link
Member Author

@rt4914 Thanks You.
Now can I pick next Issue?

@rt4914 rt4914 merged commit 1b2b8dc into oppia:develop Oct 16, 2021
@bkaur-bkj
Copy link
Contributor

@rt4914 Thanks You. Now can I pick next Issue?

Yes by the time the PR gets approved and merged u can request to work on other issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants