Fix part of #295: Change the CircleCI workflow #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitamurthi
changed the title
|
@seanlip @BenHenning PTAL! |
seanlip
reviewed
Nov 19, 2019
| assertThat(subtopicResponse.isSuccessful).isTrue() | ||
| assertThat(subtopicResponse.body()!!.subtopicTitle).isEqualTo("Subtopic 1") | ||
| } | ||
| // @Test |
There was a problem hiding this comment.
Weird to see all this commented out. Is it intentional?
There was a problem hiding this comment.
Oops, that was not intentional..removed it
|
/cc @kevinlee12 would you be up for taking a look at this PR, since you're familiar with CircleCI on oppia/oppia? |
seanlip
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
LGTM, though with the caveat that I'm not super familiar with CircleCI config -- I'll ping @kevinlee12 to ask if he has any comments based on his experience with oppia-web.
BenHenning
reviewed
Nov 20, 2019
| return JSONObject(json).toString() | ||
| return try { | ||
| JSONObject(json).toString() | ||
| } catch(e: JSONException) { |
BenHenning
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Thanks @vinitamurthi! Let's reference #295 in this PR, as well.
vinitamurthi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR makes some changes to the circleCI workflow:
Follow up PRs will slowly move the flaky tests into the non-flaky queue and then we can finally block submit on this
Also fix a network interceptor test
Fixes part of Fix all broken tests on develop #295
Checklist