Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #16: Implementation of PinPasswordActivity #328

Merged
merged 158 commits into from
Dec 13, 2019

Conversation

jamesxu0
Copy link
Contributor

Explanation

Fixes part of #16: Implementation of PinPasswordActivity. Also, it implements DialogFragments to allow the user to change their PIN. Note the base branch is not develop but refers to PR #327.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@jamesxu0 jamesxu0 changed the base branch from implement-add-profile-fragment to develop December 5, 2019 19:22
@jamesxu0
Copy link
Contributor Author

jamesxu0 commented Dec 5, 2019

@BenHenning PTAL. I addressed the comments from your first review.

@jamesxu0 jamesxu0 assigned BenHenning and unassigned jamesxu0 Dec 5, 2019
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Left a few comments--please resolve this. Otherwise, primarily deferring to Rajat's review. I didn't notice anything particularly concerning after a quick pass over the PR.

@BenHenning BenHenning assigned jamesxu0 and unassigned BenHenning Dec 11, 2019
@jamesxu0 jamesxu0 merged commit aa75a78 into develop Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants