Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40 & #42: Highfi Submitted answer #3273

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 7, 2021

Explanation

Earlier this PR was closed at #3187 because of too many changes.

Fixes part of #40
Fixes part of #42

This PR focuses on complete Highfi of Submitted Answers

Outer Margins Resources

Exploration Mobile Portrait
Exploration Mobile Landscape
Exploration Tablet Portrait
Exploration Tablet Landscape
Question Mobile Portrait
Question Mobile Landscape
Question Tablet Portrait
Question Tablet Landscape

Inner Margin Resources

https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/92b8180c-733d-46f2-b2d6-5c07f7c56680/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/2df353ea-dcf7-4dc9-9008-e43ab14378f1/
https://xd.adobe.com/view/dfe8ccd4-39eb-414d-a0b2-b5674357f966-8abb/screen/e30f0d1b-5618-4f02-b3b7-58fa92e9a14c/

Output

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jun 8, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 8, 2021
@rt4914 rt4914 merged commit a8de5cf into develop Jun 8, 2021
@rt4914 rt4914 deleted the highfi-submitted-answer-1 branch June 8, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants