Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #3242: Hi-Fi User Profile Tablet #3264

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Jun 1, 2021

Explanation

Fixes part of #3242

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested a review from rt4914 as a code owner June 1, 2021 09:39
@anandwana001 anandwana001 changed the title Fix #3242: Hi-Fi User Profile Tablet Fix part of #3242: Hi-Fi User Profile Tablet Jun 2, 2021
@anandwana001 anandwana001 assigned anandwana001 and unassigned rt4914 Jun 2, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 3, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on your TODO.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Jun 4, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jun 4, 2021

Blocking on your TODO.

@anandwana001 Convert the profile deletion alert dialog to DialogFragment similar to ExitProfileDialogFragment and that should persist during config change.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 7, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jun 7, 2021

@anandwana001 In ProfileEditActivityTest tests are failing on CI.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Jun 7, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 7, 2021
@anandwana001
Copy link
Contributor Author

@anandwana001 In ProfileEditActivityTest tests are failing on CI.

missed to update the id, all are passing now. PTAL

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 removed their assignment Jun 8, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jun 8, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 8, 2021

Hi @anandwana001, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@anandwana001 anandwana001 merged commit 090f7b1 into oppia:develop Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants