Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #16 and #44: Implementation of ProfileChooserFragment #326

Merged
merged 86 commits into from
Dec 5, 2019

Conversation

jamesxu0
Copy link
Contributor

@jamesxu0 jamesxu0 commented Nov 11, 2019

Explanation

Fixes part of #16 and #44: Implementation of ProfileChooserFragment. It also introduces ProfileTestHelper to help other test cases initialize admin and user profiles. Note the base branch is not develop but refers to PR #269.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@jamesxu0
Copy link
Contributor Author

@BenHenning @rt4914 PTAL. I addressed all comments and fixed the test case.

@jamesxu0 jamesxu0 assigned rt4914 and BenHenning and unassigned jamesxu0 Nov 27, 2019
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test case issue which needs nit change.

@rt4914 rt4914 removed their assignment Nov 28, 2019
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesxu0. This LGTM except the bit about changing the activity's children within a child. If that's going to go away in a subsequent PR, please feel free to ignore. If not, please fix here & re-assign to me if you think it's necessary. Otherwise, feel free to merge this in once comments are resolved.

@jamesxu0 jamesxu0 changed the base branch from Implement-profile-management-controller to develop December 5, 2019 18:04
@jamesxu0 jamesxu0 merged commit 04391ef into develop Dec 5, 2019
@BenHenning BenHenning deleted the implement-profile-chooser-fragment branch June 10, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants