-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #16 and #44: Implementation of ProfileChooserFragment #326
Conversation
…-profile-chooser-fragment
…-profile-chooser-fragment
@BenHenning @rt4914 PTAL. I addressed all comments and fixed the test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test case issue which needs nit change.
app/src/sharedTest/java/org/oppia/app/profile/ProfileChooserFragmentTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jamesxu0. This LGTM except the bit about changing the activity's children within a child. If that's going to go away in a subsequent PR, please feel free to ignore. If not, please fix here & re-assign to me if you think it's necessary. Otherwise, feel free to merge this in once comments are resolved.
Explanation
Fixes part of #16 and #44: Implementation of ProfileChooserFragment. It also introduces ProfileTestHelper to help other test cases initialize admin and user profiles. Note the base branch is not develop but refers to PR #269.
Checklist