Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2813: [A11y] Added label for ExplorationPlayerActivity #3229

Merged
merged 1 commit into from
May 23, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 23, 2021

Explanation

Fixes #2813: [A11y] Added label for ExplorationPlayerActivity

This PR does two tasks:

  1. Add label so that when the ExplorationActivity opens the screen reader outputs Exploration Player instead of Oppia
  2. While using screen reader it was not possible to swipe/select the toolbar title text so I have updated the click listener so that it was correctly.

You can notice both changes in before and after video.

Before PR

a11y_exploration_toolbar.mp4

After PR

correct_a11y_exploration.mp4

Screenshot 2021-05-24 at 3 32 07 AM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented May 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 23, 2021
@rt4914 rt4914 self-assigned this May 23, 2021
@rt4914 rt4914 enabled auto-merge (squash) May 23, 2021 22:31
@rt4914 rt4914 merged commit dc6baff into develop May 23, 2021
@rt4914 rt4914 deleted the a11y-exploration-player branch May 23, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for ExplorationPlayerActivity
2 participants