Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3223: High-fi Rtl support Profile Edit screen. #3224

Merged
merged 1 commit into from
May 23, 2021

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented May 22, 2021

Explanation

This PR fixes #3223. Fixes the profile name alignment.

Screenshot LTR and RTL

screenshot ..... screenshot
screenshot ...... screenshot

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs requested a review from rt4914 as a code owner May 22, 2021 19:43
@veena14cs veena14cs changed the title Fix #3223: High-fi Rtl support Profile Edit screent Fix #3223: High-fi Rtl support Profile Edit screen. May 22, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) May 23, 2021 21:29
@oppiabot oppiabot bot unassigned rt4914 May 23, 2021
@oppiabot
Copy link

oppiabot bot commented May 23, 2021

Unassigning @rt4914 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 23, 2021
@rt4914 rt4914 merged commit a6febb1 into oppia:develop May 23, 2021
@veena14cs veena14cs deleted the rtl-edit-profile branch May 26, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RTL] High-fi Edit Profile Screen.
2 participants