Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3138: Answer is improperly aligned in exploration #3172

Merged
merged 2 commits into from
May 7, 2021
Merged

Fix #3138: Answer is improperly aligned in exploration #3172

merged 2 commits into from
May 7, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 6, 2021 •
edited
Loading

Explanation

Fixes #3138

Before vs. After

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Fix #3138Bug fixed Fix #3138: Answer is improperly aligned in exploration May 6, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 7, 2021
@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 7, 2021
@rt4914 rt4914 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
MaskedCarrot
MaskedCarrot approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@MaskedCarrot MaskedCarrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@MaskedCarrot MaskedCarrot removed their assignment May 7, 2021
anandwana001
anandwana001 approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 7, 2021
@rt4914 rt4914 merged commit 5976c32 into develop May 7, 2021
@rt4914 rt4914 deleted the submitted-answer-bug branch May 7, 2021 09:15
@BenHenning BenHenning added the PR: Cherrypick requested Indicates that a PR is being requested for being cherrypicked into the ongoing release branch. label May 8, 2021
@BenHenning
Copy link
Member

Not a serious bug, but if we're spinning another MR2 build it'd be nice to pick this up since it seems like a safe change.

@rt4914 rt4914 mentioned this pull request May 11, 2021
Merged
8 tasks
@BenHenning
Copy link
Member

This did not end up being cherry-picked so marking it as denied (to avoid confusion in future audits).

@BenHenning BenHenning added the PR: Cherrypick denied Indicates a PR has been denied to be cherrypicked into the latest release branch. label Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@MaskedCarrot MaskedCarrot MaskedCarrot approved these changes

Assignees

@rt4914 rt4914

Labels
PR: Cherrypick denied Indicates a PR has been denied to be cherrypicked into the latest release branch. PR: Cherrypick requested Indicates that a PR is being requested for being cherrypicked into the ongoing release branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Answer is improperly aligned in exploration
4 participants
@rt4914 @BenHenning @anandwana001 @MaskedCarrot