-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #40 and Fixes part of #42: Highfi ItemSelectionInteraction + A11y #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rt4914
changed the title
Highfi work finished
Fixes part of #40 and Fixes part of #42: Highfi work finished
May 6, 2021
rt4914
changed the title
Fixes part of #40 and Fixes part of #42: Highfi work finished
Fixes part of #40 and Fixes part of #42: Highfi work finished + A11y
May 6, 2021
rt4914
changed the title
Fixes part of #40 and Fixes part of #42: Highfi work finished + A11y
Fixes part of #40 and Fixes part of #42: Highfi ItemSelectionInteraction + A11y
May 6, 2021
anandwana001
added
the
PR don't merge - NEEDS UPDATE
Corresponds to PRs that need to be updated with the latest develop changes before they can be merged
label
May 7, 2021
rt4914
removed
the
PR don't merge - NEEDS UPDATE
Corresponds to PRs that need to be updated with the latest develop changes before they can be merged
label
May 7, 2021
anandwana001
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes part of #40 and fixes part of #42
Fixes #2312 and Fixes #2313
Note: This PR focuses only on the internal UI of
ItemSelectionInteraction
and external margins are not part of this PR.Also, bottom margin for
feedback_item
has been removed as it won't affect the UI.Resources
Mobile Portrait - Single Choice
Mobile Portrait - Multi Choice
Mobile Portrait - 2
Mobile Landscape
Tablet Portrait
Tablet Landscape
Screenshots
A11y
multi_item_selection_a11y.mp4
single_item_selection_a11y.mp4
Test Results
The tests which are failing are not part of this PR. Filed an issue: #3171
Checklist