Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40 and Fixes part of #42: Highfi ItemSelectionInteraction + A11y #3170

Merged
merged 9 commits into from
May 11, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 6, 2021

Explanation

Fixes part of #40 and fixes part of #42

Fixes #2312 and Fixes #2313

Note: This PR focuses only on the internal UI of ItemSelectionInteraction and external margins are not part of this PR.
Also, bottom margin for feedback_item has been removed as it won't affect the UI.

Resources

Mobile Portrait - Single Choice
Mobile Portrait - Multi Choice
Mobile Portrait - 2
Mobile Landscape
Tablet Portrait
Tablet Landscape

Screenshots

A11y

multi_item_selection_a11y.mp4
single_item_selection_a11y.mp4

Test Results

The tests which are failing are not part of this PR. Filed an issue: #3171

Screenshot 2021-05-06 at 6 00 39 PM

Screenshot 2021-05-06 at 6 13 13 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Highfi work finished Fixes part of #40 and Fixes part of #42: Highfi work finished May 6, 2021
@rt4914 rt4914 changed the title Fixes part of #40 and Fixes part of #42: Highfi work finished Fixes part of #40 and Fixes part of #42: Highfi work finished + A11y May 6, 2021
@rt4914 rt4914 requested a review from BenHenning as a code owner May 6, 2021 12:51
@rt4914 rt4914 requested a review from anandwana001 May 6, 2021 12:51
@rt4914 rt4914 changed the title Fixes part of #40 and Fixes part of #42: Highfi work finished + A11y Fixes part of #40 and Fixes part of #42: Highfi ItemSelectionInteraction + A11y May 6, 2021
@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@rt4914 rt4914 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

just a small thing, I run these tests on latest develop branch, and I got a bit more fail test, could you confirm with this PR if this PR solved any test.

Also, It will be helpful if you add a ignore annotation on these failing test.

Screenshot 2021-05-11 at 10 31 20

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 11, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented May 11, 2021

LGTM,

just a small thing, I run these tests on latest develop branch, and I got a bit more fail test, could you confirm with this PR if this PR solved any test.

Also, It will be helpful if you add a ignore annotation on these failing test.

Screenshot 2021-05-11 at 10 31 20

Done.
Screenshot 2021-05-11 at 1 38 50 PM

@rt4914 rt4914 merged commit ed0f274 into develop May 11, 2021
@rt4914 rt4914 deleted the item-selection-a11y branch May 11, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Item Selection Interaction Items [A11y] Changes in Multiple Choice Interaction Item [A11y]
2 participants