Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3062: Label added to AdministratorControlsActivity. #3152

Merged

Conversation

jkugsiya
Copy link
Contributor

@jkugsiya jkugsiya commented May 1, 2021

Explanation

Fixes #3062 : Added label to AdministratorControlsActivity.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshot of successful test:

RunTest

@anandwana001
Copy link
Contributor

@jkugsiya jkugsiya removed their assignment May 3, 2021
@jkugsiya jkugsiya requested a review from anandwana001 May 3, 2021 02:37
@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 3, 2021

@anandwana001 anandwana001 self-assigned this May 3, 2021
@anandwana001
Copy link
Contributor

@jkugsiya Could you confirm, if you have access to the Assignee section?

@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 3, 2021

@jkugsiya Could you confirm, if you have access to the Assignee section?

No, I don't have access to that!
image

@anandwana001 anandwana001 assigned rt4914 and jkugsiya and unassigned anandwana001 and jkugsiya May 3, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkugsiya Thanks.

@rt4914 rt4914 assigned jkugsiya and unassigned rt4914 May 4, 2021
@jkugsiya jkugsiya removed their assignment May 5, 2021
@jkugsiya jkugsiya requested a review from rt4914 May 5, 2021 03:28
@rt4914 rt4914 self-assigned this May 5, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkugsiya One nit change.

Also, this PR contains changes related to formatting of the AndroidManifest and strings file which I think is correct change otherwise other contributors will face this same issue. But I will defer to @BenHenning about this.

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned BenHenning and jkugsiya and unassigned rt4914 and BenHenning May 5, 2021
@jkugsiya jkugsiya removed their assignment May 5, 2021
@jkugsiya jkugsiya requested a review from rt4914 May 5, 2021 13:05
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 7, 2021

I've updated the fork's branch and that is reflecting the changes and showing that it is up-to-date. https://github.com/jkugsiya/oppia-android/tree/A11y-AdministratorControlsActivity
updated

But I don't know why the same is not reflecting in the PR.
notUpdated

Can someone help me resolve this problem?

@anandwana001
Copy link
Contributor

@jkugsiya As Fetch Upstream is something GitHub has released on the repository directly, but this will not push to your PR. This is only updating your branch on the fork, not pushed into the PR.

@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 7, 2021

@jkugsiya As Fetch Upstream is something GitHub has released on the repository directly, but this will not push to your PR. This is only updating your branch on the fork, not pushed into the PR.

How can I push to the PR then? As all the changes are done and there's nothing to commit more.

@anandwana001
Copy link
Contributor

You need to check if your local PR branch is synced with the repository or not. If not then git pull and update the PR, and then you need to push to this PR.

@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 7, 2021

You need to check if your local PR branch is synced with the repository or not. If not then git pull and update the PR, and then you need to push to this PR.

Already done the specified. Still no luck! Shows Everything up-to-date
image

@jkugsiya
Copy link
Contributor Author

jkugsiya commented May 7, 2021

You need to check if your local PR branch is synced with the repository or not. If not then git pull and update the PR, and then you need to push to this PR.

Already done the specified. Still no luck! Shows Everything up-to-date
image

It automatically appeared now, without doing anything. It could have been an issue with GitHub. Thanks @anandwana001 !!
image

@jkugsiya jkugsiya removed their assignment May 7, 2021
@anandwana001 anandwana001 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkugsiya. This LGTM.

@BenHenning
Copy link
Member

@anandwana001 I think you're requesting changes which is blocking this PR--PTAL.

@BenHenning BenHenning assigned anandwana001 and unassigned BenHenning May 8, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 4e5c4ec into oppia:develop May 8, 2021
@jkugsiya jkugsiya deleted the A11y-AdministratorControlsActivity branch May 9, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for AdministratorControlsActivity
4 participants