Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #2613: A11y Onboarding Flow #3105

Merged
merged 10 commits into from
Apr 26, 2021
Merged

Fix part of #2613: A11y Onboarding Flow #3105

merged 10 commits into from
Apr 26, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Apr 20, 2021 •
edited
Loading

Explanation

Fixes part of #2613 : The bottom dots now read as progress like "Slide n of 4" where n is the slide number.

Screenshot of tests passing
Screenshot from 2021-04-24 00-35-41

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yashraj-01 yashraj-01 requested a review from rt4914 as a code owner April 20, 2021 19:28
@yashraj-01
Copy link
Contributor Author

@rt4914 PTAL. If the approach is correct then I'll write tests for it as well. Thanks.

@anandwana001
Copy link
Contributor

@yashraj-iitr Please follow the guide - https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

@yashraj-01
Copy link
Contributor Author

@yashraj-iitr Please follow the guide - https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section

Apologies. I forgot. Thanks for reminding.

rt4914
rt4914 suggested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to check that the content description is correctly set.

app/src/main/java/org/oppia/android/app/onboarding/OnboardingViewModel.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/onboarding_fragment.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned yashraj-01 and unassigned rt4914 Apr 22, 2021
@yashraj-01
Copy link
Contributor Author

I have written tests to check that the content description is correctly set. @rt4914 PTAL.

@yashraj-01 yashraj-01 assigned rt4914 and unassigned yashraj-01 Apr 23, 2021
rt4914
rt4914 suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashraj-iitr Suggested changes.

app/src/main/res/layout-sw600dp-land/onboarding_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/onboarding/OnboardingFragmentTest.kt Show resolved Hide resolved
@yashraj-01
Copy link
Contributor Author

I have addressed all the comments. @rt4914 PTAL.

@yashraj-01 yashraj-01 assigned rt4914 and unassigned rt4914 Apr 23, 2021
rt4914
rt4914 suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashraj-iitr I have replied to one open comment. PTAL

@rt4914 rt4914 assigned yashraj-01 and unassigned rt4914 Apr 26, 2021
@yashraj-01 yashraj-01 assigned rt4914 and unassigned yashraj-01 Apr 26, 2021
rt4914
rt4914 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@rt4914 rt4914 merged commit 11a1c01 into oppia:develop Apr 26, 2021
@yashraj-01 yashraj-01 mentioned this pull request May 5, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashraj-01 @anandwana001 @rt4914