Partially fixed #16: Introduced fragment components for profile editing in settings #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jamesxu0. Deferring this review for now until my comment in your document is resolved about whether these should actually be fragments vs. activities. Please assign back to me once that's finalized & this PR is up-to-date (if changes are needed). |
|
@BenHenning PTAL. Changed ProfileRenameFragment and ProfileResetPinFragment to ProfileRenameActivity and ProfileResetPinActivity. |
BenHenning
approved these changes
Nov 12, 2019
app/src/main/java/org/oppia/app/settings/profile/ProfileDeletionDialogFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/settings/profile/ProfileListFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/settings/profile/ProfileListFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Partially fixing #16: Introduced fragment components for profile editing in settings. Introduces ProfileListFragment, ProfileEditFragment, AdminAuthFragment, and AddProfileFragment.
Checklist