-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #2003: Modified the use of space_20 #2010
Conversation
@Arjupta considering that you are now a collaborator. Please make sure that you Keep the |
1 similar comment
@Arjupta considering that you are now a collaborator. Please make sure that you Keep the |
Also, @Arjupta You can work on other issues meanwhile we start discussion about the the naming on this PR with other team mates. @BenHenning Can you have a look at the naming convention for dimensions and leave your thoughts? |
Okay, I will follow them from now on. Mistakenly closed this PR while using the Github Mobile App |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arjupta could you assign me as well for all of your future PR's. |
Okay, I will take care of that. |
@BenHenning PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The names LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arjupta One nit and rest all is good.
@rt4914 I think this is ready to merge, shall I proceed with PR related to other dimensions now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
You can start creating other parts but make sure they are still smaller PRs as it will create less merge conflicts and fast approvals.
Roughly I think you can change nearly 10-15 files for such issues in single PR.
Sure will take care of that. Can I know whether I should ask for a review on this issue from you or Ben? Thanks |
You can ask me and if I will have any doubt I will add @BenHenning too. |
Explanation
Fixes part of #2003
This commit removes the use of dimension space_20 with the dimensions of use-case specific names.
Checklist