Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1948: Optimize code in onboarding_fragment.xml files #1984

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix #1948: Optimize code in onboarding_fragment.xml files #1984

merged 1 commit into from
Oct 13, 2020

Conversation

Austinepass
Copy link
Contributor

@Austinepass Austinepass commented Oct 11, 2020 •
edited
Loading

Fix #1948: Styled the TextViews with appropriate styles defined in the style.xml file

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Austinepass Austinepass changed the title Fix #1948: Optimize code in onboarding fragment.xml files Fix #1948: Optimize code in onboarding_fragment.xml files Oct 11, 2020
@rt4914 rt4914 self-requested a review October 12, 2020 13:25
@rt4914 rt4914 self-assigned this Oct 12, 2020
@Austinepass
Copy link
Contributor Author

@rt4914 I await your review on this particular PR. Thanks

rt4914
rt4914 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a very clean and nice implementation.
Thanks @Austinepass
Merging this now.

@rt4914 rt4914 merged commit 78876bc into oppia:develop Oct 13, 2020
@Austinepass
Copy link
Contributor Author

Thats a very clean and nice implementation.
Thanks @Austinepass
Merging this now.

I'm glad you approved it.

@Austinepass Austinepass deleted the Fix#1948-optimize-code-in-onboarding-fragment-xml branch October 14, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise code in onboarding_fragment.xml
2 participants
@Austinepass @rt4914