Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1950: Optimise help_item.xml #1972

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix #1950: Optimise help_item.xml #1972

merged 1 commit into from
Oct 13, 2020

Conversation

Arjupta
Copy link
Contributor

@Arjupta Arjupta commented Oct 10, 2020

Explanation

Fixes #1950 , Used custom style "Subtitle1" to optimise help_item.xml

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.
    @rt4914

@Arjupta
Copy link
Contributor Author

Arjupta commented Oct 10, 2020

@rt4914 PTAL

Sarthak2601
Sarthak2601 approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Arjupta !

BenHenning
BenHenning approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Arjupta!

@BenHenning BenHenning merged commit 9763e84 into oppia:develop Oct 13, 2020
@BenHenning BenHenning changed the title Fix #1950 : Optimise help_item.xml Fix #1950: Optimise help_item.xml Oct 13, 2020
@Arjupta Arjupta deleted the optimise-help-item branch October 14, 2020 19:13
@aggarwalpulkit596
Copy link
Contributor

give @Arjupta 5 points

@BenHenning BenHenning mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@Sarthak2601 Sarthak2601 Sarthak2601 approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise code in help_item.xml
5 participants
@Arjupta @aggarwalpulkit596 @BenHenning @Sarthak2601 @rt4914