-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1887: Thoroughly test FractionInputHasNumeratorEqualToRuleClassifierProvider #1927
Fix #1887: Thoroughly test FractionInputHasNumeratorEqualToRuleClassifierProvider #1927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheRealJessicaLi! Apologies for the delayed review. This looks good--just left a couple of comments including some ideas for additional tests.
...n/classify/rules/fractioninput/FractionInputHasNumeratorEqualToRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...n/classify/rules/fractioninput/FractionInputHasNumeratorEqualToRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
72507a9
to
220d618
Compare
220d618
to
b68f3c0
Compare
b68f3c0
to
4ba842b
Compare
@TheRealJessicaLi Please do not do any force push. (cc @BenHenning ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheRealJessicaLi. PR LGTM!
Couple things:
-
When resolving a comment thread, please 'resolve' it by leaving a comment (not by clicking the 'resolve' button). Authors will resolve the thread after verifying it's resolved. This helps us keep better track of comments since longer PRs have dozens of them across multiple review passes.
-
As @rt4914 mentioned, please never force submit. There are rare occasions where it's necessary, and if you hit such a case please follow up with us first. Force submission breaks history (per its nature), which leads to losing comments & conversation threads. In this case, I needed to re-review the whole PR rather than just your latest changes.
…lassifierProvider (oppia#1927) * added tests to test numerator equality * linted * fixed as per comments
…lassifierProvider (oppia#1927) * added tests to test numerator equality * linted * fixed as per comments
@BenHenning PTAL
Explanation
Fixes #1887 by adding unit tests for FractionInputHasNumeratorEqualToRuleClassifierProvider.
Checklist