-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1908:Changed comments in Proto files #1917
Fix #1908:Changed comments in Proto files #1917
Conversation
@Victor-Titan it was fixed in the latest development or you just explicitly avoided that file? |
It was fixed in the latest developement |
LGTM Thanks :) |
@Victor-Titan Is your issue resolved? |
@prayutsu Yeah my issue is resolved |
@Victor-Titan PR looks good to me, Thanks!! |
@aggarwalpulkit596 @prayutsu Since you've both approved the PR, do I have to tag someone else for it to be merged or the merge will occur when an authorized user is free to look at the list of approved PRs? |
Just wait for some time, It will get merged most probably by tomorrow morning |
@Victor-Titan it's usually merged by someone on the team but since this one is your first PR, I wanted one more member to approve the request before i merge the req. |
@aggarwalpulkit596 So should I tag someone else as well? |
I have already assigned it to @anandwana001. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @Victor-Titan
@aggarwalpulkit596 You can merge this one.
Explanation
Checklist