Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi Landscape mode for StoryActivity #634

Closed
2 tasks
rt4914 opened this issue Jan 30, 2020 · 3 comments · Fixed by #636
Closed
2 tasks

Lowfi Landscape mode for StoryActivity #634

rt4914 opened this issue Jan 30, 2020 · 3 comments · Fixed by #636
Assignees
@PrarabdhGarg
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 30, 2020

Mock Link:
https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/cce938d6-e079-4761-bac0-8bde22ac6348/TP-CL-Auto-Scroll-Button-

https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/2cf61633-3197-4445-adb0-b58fbe418b11/TP-CL-Auto-Scroll-Button-

Checklist

  • Landscape mode UI
  • Test cases for landscape mode.
@rt4914
Copy link
Contributor Author

rt4914 commented Jan 30, 2020

Assigning this to @PrarabdhGarg

@PrarabdhGarg
Copy link
Contributor

@rt4914 where do I write the tests for the Story Activity? In the file that is present in the app package, or the file present in the sharedTest package?
Also, why are there two files serving the same purpose?

@PrarabdhGarg PrarabdhGarg mentioned this issue Feb 3, 2020
Merged
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 3, 2020

@rt4914 where do I write the tests for the Story Activity? In the file that is present in the app package, or the file present in the sharedTest package?
Also, why are there two files serving the same purpose?

The file which is present in the sharedTest StoryFragmentTest https://github.com/oppia/oppia-android/blob/develop/app/src/sharedTest/java/org/oppia/app/story/StoryFragmentTest.kt

The testing package in app module is actually for those items which needs to be tested separately and cannot be tested in regular android app structure. So in such cases, we create a dummy activity which has some fake implementation and then the test cases for that dummy activity is written in sharedTest

@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Worksteam: Landscape labels Feb 12, 2020
rt4914 pushed a commit that referenced this issue Feb 13, 2020
@PrarabdhGarg
Fix #634: Lowfi landscape story activity (#636)
9a92b88 
* Add landscape UI layout for story activity

* Add test case for landscape layout

* Minor style changes and add a test case

* Update test cases

* Resolve issue with story fragment test cases not passing

* Minor edits
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrarabdhGarg PrarabdhGarg

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #634: Lowfi landscape story activity PrarabdhGarg/oppia-android
3 participants
@rt4914 @BenHenning @PrarabdhGarg