Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11YS] - Improve accessibility for confetti text #4701

Closed
vrajdesai78 opened this issue Nov 8, 2022 · 0 comments · Fixed by #4702
Closed

[A11YS] - Improve accessibility for confetti text #4701

vrajdesai78 opened this issue Nov 8, 2022 · 0 comments · Fixed by #4702

Comments

@vrajdesai78
Copy link
Contributor

vrajdesai78 commented Nov 8, 2022 •
edited
Loading

Describe the bug
Accessibility scanner is showing suggestions to improve text scaling and color contrast ratio for confetti text.

To Reproduce
Steps to reproduce the behavior:

  1. Turn on accessibility scanner
  2. Play exploration
  3. Submit correct answer

Expected behavior
Accessibility scanner should not show any improvement

Screenshot
image

Environment

  • Device/emulator being used: Realme GT Master Edition
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 1.0
@vrajdesai78 vrajdesai78 mentioned this issue Nov 8, 2022
Merged
6 tasks
@vrajdesai78 vrajdesai78 changed the title [A11Y] - Improve accessibility for congratulations text [A11Y] - Improve accessibility for confetti text Nov 8, 2022
@vrajdesai78 vrajdesai78 changed the title [A11Y] - Improve accessibility for confetti text [A11YS - Improve accessibility for confetti text Nov 8, 2022
@vrajdesai78 vrajdesai78 changed the title [A11YS - Improve accessibility for confetti text [A11YS] - Improve accessibility for confetti text Nov 8, 2022
rt4914 pushed a commit that referenced this issue Nov 9, 2022
@vrajdesai78
Fixes #4701: Improve accessibility for confetti text (#4702)
acece86 
## Explanation
Fixes #4701: Improved accessibility for congratulations text by changing
height to wrap_content and improved contrast ratio by changing color in
color pallet.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).


## Screenshot 

Before         |  After
:-------------------------:|:-------------------------:

![image](https://user-images.githubusercontent.com/43074241/200644040-416efbc0-cced-457d-91b3-da8b2c5d877e.png)
|
![image](https://user-images.githubusercontent.com/43074241/200643995-580d2b9c-2742-483c-81dd-18948b4e66f8.png)
adhiamboperes pushed a commit to adhiamboperes/oppia-android that referenced this issue Nov 10, 2022
@vrajdesai78 @adhiamboperes
Fixes oppia#4701: Improve accessibility for confetti text (oppia#4702)
db6ee38 
## Explanation
Fixes oppia#4701: Improved accessibility for congratulations text by changing
height to wrap_content and improved contrast ratio by changing color in
color pallet.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).


## Screenshot 

Before         |  After
:-------------------------:|:-------------------------:

![image](https://user-images.githubusercontent.com/43074241/200644040-416efbc0-cced-457d-91b3-da8b2c5d877e.png)
|
![image](https://user-images.githubusercontent.com/43074241/200643995-580d2b9c-2742-483c-81dd-18948b4e66f8.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4701: Improve accessibility for confetti text vrajdesai78/oppia-android
1 participant
@vrajdesai78