Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the design of the chapter list in lessons tab #4449

Closed
JishnuGoyal opened this issue Jul 22, 2022 · 3 comments · Fixed by #4621
Closed

Modify the design of the chapter list in lessons tab #4449

JishnuGoyal opened this issue Jul 22, 2022 · 3 comments · Fixed by #4621
Assignees
@JishnuGoyal
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@JishnuGoyal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The chapters (recycler items) on the lessons tab do not look clickable. Users do not get an idea of how to start a chapter from that screen.

Describe the solution you'd like
Modify the design of the chapter list so that it clearly shows chapters that are completed, ready to start and locked. Also, make sure that the chapter list drop down is open by default.
@JishnuGoyal JishnuGoyal self-assigned this Jul 27, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_enhancement Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
BenHenning added a commit that referenced this issue Sep 20, 2022
@BenHenning
Revert "Fix #4449: Modify the design of the chapter list in lessons t…
3a98829 
…ab (#4535)"

This reverts commit e91de5d.
BenHenning added a commit that referenced this issue Sep 21, 2022
@BenHenning
Revert "Fix #4449: Modify the design of the chapter list in lessons t…
7e4f2dd 
…ab (#4535)" (#4603)

This reverts commit e91de5d.
@BenHenning
Copy link
Member

Reopening since #4535 was reverted in #4603.

@BenHenning BenHenning reopened this Sep 21, 2022
@BenHenning
Copy link
Member

#4604 may be helpful when looking into fixing the issues.

@JishnuGoyal
Copy link
Contributor Author

Thanks, I'll be following up on this.

This was referenced Sep 22, 2022
Closed
Merged
BenHenning pushed a commit that referenced this issue Sep 24, 2022
@JishnuGoyal
Fix #4602, #4449: Modify the design of the chapter list in lessons tab (
dc23e47 
#4621)

Includes the fast-forward fix so that develop doesn't break.

Original PR: #4535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JishnuGoyal JishnuGoyal

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
3 participants
@BenHenning @JishnuGoyal @Broppia