Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Proto Definitions for Performance Metrics collection #4328

Closed
Sarthak2601 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4336
Closed

Add Proto Definitions for Performance Metrics collection #4328

Sarthak2601 opened this issue Apr 27, 2022 · 0 comments · Fixed by #4336
Assignees
@Sarthak2601
Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

This issue tracks the implementation of protocol buffer definitions for the process of Performance Metrics collection. These definitions would play a key role while logging these metrics. We'll be defining the following metrics:

  • Timestamp
  • Priority
  • a boolean to know whether app is in foreground or not
  • Memory tier of the device [ =<1GB, =<2GB && >1GB, >2GB ]
  • Storage tier of the device [ =<5GB, =<20GB && >5GB, >20GB ]
  • Network type of the device [ none, wifi, cellular ]
  • Current Activity.
@Sarthak2601 Sarthak2601 self-assigned this Apr 27, 2022
@Sarthak2601 Sarthak2601 changed the title Performance Metrics Proto Definitions Add Proto Definitions for Performance Metrics collection Apr 27, 2022
@Sarthak2601 Sarthak2601 mentioned this issue Apr 30, 2022
Merged
6 tasks
@Sarthak2601 Sarthak2601 linked a pull request Apr 30, 2022 that will close this issue
Fixes #4328: Proto definitions for performance metrics collection #4336
Merged
6 tasks
@Broppia Broppia added issue_type_dev_initiated Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 2, 2022
Sarthak2601 added a commit that referenced this issue Jul 26, 2022
@Sarthak2601
Fixes #4328: Proto definitions for performance metrics collection (#4336
ee8fdc6 
)

* qualifiers and constants for metric record and upload times

* comments

* dagger provides for flags

* rename to enablePerformanceMetricCollection

* initial proto

* nit fixes

* nit fixes

* comments.

* nits

* nit

* updates.

* updates.

* nits.

* metric log inclusion.

* name correction.

* nits.

* storage comment

* pss comment

* network usage comment.

* network usage comment - part 2.

* metric addition in proto definitions.

* metricLog --> loggableMetric

* wording update for transmission

* memory and storage tier updates
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sarthak2601 Sarthak2601

Labels
Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #4328: Proto definitions for performance metrics collection oppia/oppia-android
3 participants
@BenHenning @Sarthak2601 @Broppia