Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for whitespace & fractions patterns #414

Closed
BenHenning opened this issue Nov 19, 2019 · 4 comments · Fixed by #3154 or #3214
Closed

Add tests for whitespace & fractions patterns #414

BenHenning opened this issue Nov 19, 2019 · 4 comments · Fixed by #3154 or #3214
Assignees
@viktoriias
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

See #413 for details.
@BenHenning BenHenning mentioned this issue Nov 19, 2019
Merged
@BenHenning
Copy link
Member Author

Examples of interesting tests @nikitamarysolomanpvt has been doing that we should replicate later with automated tests:

  • Single & multi digit terms
  • Negatives
  • Variable spaces between terms
  • Verifying that numerator & denominator are correct for fraction-only, whole number-only, and mixed number fractions

@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@BenHenning
Copy link
Member Author

BenHenning commented Apr 7, 2021 •
edited
Loading

To be more clear: this is proposing that we introduce a well-tested StringToFractionParserTest class for StringToFractionParser (there are no tests for this currently).

This was referenced Apr 19, 2021
Closed
Closed
@viktoriias viktoriias mentioned this issue May 3, 2021
Merged
8 tasks
BenHenning pushed a commit that referenced this issue May 16, 2021
@viktoriias
Fix #414: Add StringToFractionParserTest (#3154)
96b119d 
* Add StringToFractionParserTest.

* lint

* Add PracticeTabModule.

* test

* test

* Change tests naming.
rt4914 added a commit that referenced this issue May 18, 2021
@rt4914
Revert "Fix #414: Add StringToFractionParserTest (#3154)"
b76b657 
This reverts commit 96b119d.
rt4914 added a commit that referenced this issue May 18, 2021
@rt4914
Revert "Fix #414: Add StringToFractionParserTest (#3154)" (#3196)
73c9d0d 
This reverts commit 96b119d.
@rt4914
Copy link
Contributor

rt4914 commented May 18, 2021

Reverted PR in #3196

@rt4914 rt4914 reopened this May 18, 2021
@rt4914
Copy link
Contributor

rt4914 commented May 18, 2021

cc : @viktoriias

@viktoriias viktoriias mentioned this issue May 20, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue May 21, 2021
@viktoriias
Fix #414: Add StringToFractionParserTest (#3214)
808c205 
* Add StringToFractionParserTest.

* Add a newline.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktoriias viktoriias

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
3 participants
@rt4914 @viktoriias @BenHenning