Implement edit profile screen inside a fragment #4028
Assignees
Labels
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
6 tasks
|
@yash10019coder this seems to be missing some details. Can you please add code links to anything that you think should change, and be a bit clearer on what you expect the outcome to be? I'm not actually positive what exactly needs to be done to resolve this. Also, assigning this to you given that you're implementing #4029. Note that I'm not looking at that PR to understand this issue since it's generally good practice for issues to be sufficiently self-documenting to stand on their own without the PR for them already existing (consider that many issues are addressed by people other than the person who created them, so capturing the context needed to resolve the issue clearly is really important). |
BenHenning
added a commit
that referenced
this issue
Jun 7, 2022
…a fragment (#4029) * added multipane. * added fragment ProfileEditFragment opening in multipane window * added ImageButton in administrator_controls_activity.xml added logic by implementing listeners and handlers for ProfileEditFragment. * nit fixes. * removed a error creating code. * added functionality for extra controls title. * nit fixes. * added back button in extra title. * added back button in extra title. * tried to implement back stack management. * formatted the code. * added the backstack count. * formatted the code. * added back stack support and also added kotlin fragment dependency in build.gradle(:app). * changed camel case to snake case of one color property in administrator_controls_activity.xml. * added route to ProfileEditActivity * added route to ProfileEdit. * reformatted the code. * added listener in app/bazel in LISTENERS. * nit fixes. * nit fixes. * added backstack name tag. * removed an unused dependency of AdministratorControlsFragmentPresenter. * nit fix. * fixed ClassCastException. * fixed Route in listeners of app/bazel. * nit fixes for Kdocs. * nit fixes. * nit fixes. * added test files Liststers in test_file_exemptions.textproto * shorten character length. * added kdocs for methods. * nit fixes for regex validation. * shifted tests to AdministratorControlsFragmentTest.kt. * nit fixes. * added the backstack name for AdministratorControlsFragment Backstack. * created a ProfileEditFragmentTest file and added tests in it added activity label check in ProfileEditActivityTest added a test in AdministratorControlsFragmentTest.kt to check for the back button is gone. * nit fixes. * nit fixes. * added import references * added tests for profile_edit_tablet. * nit fixes for formatting. * added Coroutines Dispatcher in the test and other nit fixes. * used constructor injection instead of field injection in ProfileEditFragmentPresenter.kt * added ProfileEditViewModel observer code. * formatted the code. * changed the view model scope from activity to fragment. * nit fixes. * removed some files in kdoc_validity_exemptions.textproto * added Kdocs for AdministratorControlsActivity.kt * added Kdocs for AdministratorControlsActivityPresenter.kt * more Kdocs * nit fixes * nit fixes * nit fixes * nit fixes * nit fix for Kdoc * removed the back stack. * removed the onResume in AdministratorControlsActivity.kt. * added custom implementation for backstack. * added new implementation for back button. * bug fix for back button listener. * nit formatting fixes. * nit fixes. * nit fixes. * nit fixes. * nit fixes. * starting to implement saved state * completed state handling on configuration change. * nit fixes. * added some tests and updated the test rule. * updated ProfileEditFragmentTest.kt test rule. * broken down the checking and performing action in two steps. * Update app/src/main/java/org/oppia/android/app/administratorcontrols/LoadProfileEditListener.kt Co-authored-by: Ben Henning <[email protected]> * Update app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsViewModel.kt Co-authored-by: Ben Henning <[email protected]> * nit fixes. * used replace instead of add in fragment transactions. * nit fixes. * nit fixes. * added two tests for configuration change of tablet. * fixed configuration changes and added back button support. * added test coroutines dispatchers. * fixed typo for LoadProfileEditListener.kt * added support for configuration change of ProfileEditDeletionDialogFragment in tablet mode. * refactored names of declared listeners and also added then in app/build.bazel listeners * added tests for ProfileDeletion in tablet in AdministratorControlsFragmentTest.kt * nit fixes. * added some activity related tests in AdministratorControlsActivityTest.kt * nit fixes. * added listeners to test_file_exemptions.textproto * sorted test_file_exemptions.textproto * nit fixes. * nit fixes. * nit fixes. * removed unused imports. * added coroutine dispatchers. * nit fixes. * created test activity wrapper also added the test activity and presenter file in test and kdoc exemptions shifted and migrated tests accordingly for the Fragment and Activity of ProfileEdit. * nit fixes. * optimised and shifted some test cases. * made some helper functions shortened some tests and some nits. * nit fixes. * added a label in the activity. * Update app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivity.kt Co-authored-by: Ben Henning <[email protected]> * Update app/src/main/java/org/oppia/android/app/settings/profile/LoadProfileEditDeletionDialogListener.kt Co-authored-by: Ben Henning <[email protected]> * nit fixes. * added a wrapper test activity for AdministratorControlsFragmentTest.kt * nit fixes. * added label and nits. * fixed the test activity for AdministratorControlsFragment.kt * Apply suggestions from code review Co-authored-by: Ben Henning <[email protected]> * added helper functions for tests in AdministratorControlsFragmentTest.kt and some nit changes. * nit fixes. * Apply suggestions from code review Co-authored-by: Ben Henning <[email protected]> * nit fixes. * removed the implementation of the overridden function in AdministratorControlsFragmentTestActivity.kt * nit fixes. * Apply suggestions from code review Co-authored-by: Akshay Nandwana <[email protected]> * removed unused methods in test activity for AdministratorControlsFragment class.kt * Update app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileEditFragmentTest.kt Co-authored-by: Ben Henning <[email protected]> * nit fixes. * nit fixes. * nit formatting fixes. * added some missing view dependencies in app/BUILD.bazel * added required modules for ProfileEditFragmentTest.kt in Dependency graph. * nit fixes. Co-authored-by: Ben Henning <[email protected]> Co-authored-by: Akshay Nandwana <[email protected]>
BenHenning
added
the
Z-ibt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
issue #3241
refer to this issue for the details and impletation for this issue
this issue basically resolves the hi-fi profile in administrator controls.
Implementing edit profile screen inside a fragment
The text was updated successfully, but these errors were encountered: