Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required field label has to be right aligned in RTL. #3958

Closed
veena14cs opened this issue Oct 21, 2021 · 1 comment · Fixed by #3935
Closed

Required field label has to be right aligned in RTL. #3958

veena14cs opened this issue Oct 21, 2021 · 1 comment · Fixed by #3935
Assignees
@veena14cs
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

In Add profile screen required field has to be right aligned in RTL.

Screenshot_1634864192
@veena14cs veena14cs self-assigned this Oct 21, 2021
@veena14cs veena14cs added this to the RTL Support milestone Oct 21, 2021
@veena14cs veena14cs mentioned this issue Oct 21, 2021
Merged
6 tasks
@BenHenning
Copy link
Member

Nice catch @veena14cs. Thanks for filing this & following up with a fix.

@BenHenning BenHenning linked a pull request Oct 22, 2021 that will close this issue
Fix #3934, #3958, and #3919: [RTL] High-fi Align TextViews, description text and toolbar marquee text. #3935
Merged
6 tasks
BenHenning added a commit that referenced this issue Oct 27, 2021
@veena14cs @BenHenning
Fix #3934, #3958, and #3919: [RTL] High-fi Align TextViews, descripti…
f9accc6 
…on text and toolbar marquee text. (#3935)

* Update selection_interaction_item.xml

* Update selection_interaction_item.xml

* Update return_to_topic_button_item.xml

* Update return_to_topic_button_item.xml

* Update image_region_selection_interaction_item.xml

* Update image_region_selection_interaction_item.xml

* Fix desrciption and marquee for RTL

* added test

* Update ResumeLessonFragmentTest.kt

* fixed tests

* fixed ellipsize

* Update app/src/sharedTest/java/org/oppia/android/app/resumelesson/ResumeLessonFragmentTest.kt

Co-authored-by: Ben Henning <[email protected]>

* Update ResumeLessonFragmentTest.kt

* fix lint

* add style for marquee and description text

* add width to the style

* Update ResumeLessonFragmentTest.kt

* fixed alignment where required

* fixed textalignment

* remove alignment from heading 2 style

* fixed textstyle

* Update add_profile_activity.xml

Co-authored-by: Ben Henning <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
2 participants
@BenHenning @veena14cs