Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a BUILD.bazel file for domain/onboarding #3276

Closed
fsharpasharp opened this issue Jun 8, 2021 · 2 comments · Fixed by #3877
Closed

Create a BUILD.bazel file for domain/onboarding #3276

fsharpasharp opened this issue Jun 8, 2021 · 2 comments · Fixed by #3877
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@fsharpasharp
Copy link
Contributor

fsharpasharp commented Jun 8, 2021

This task is part of the build system migration from Gradle to Bazel.

Prerequesites

Task

  1. Create a BUILD.bazel file in

domain/src/main/java/org/oppia/android/domain/onboarding/

and

domain/src/main/java/org/oppia/android/domain/onboarding/testing

  1. Define the kt_android_library library/libraries

Based on the imports in the Kotlin files, add the required third_party dependencies to make the libraries build. Check the Useful links section for a list of third_party dependencies. You may also need to add the non third_party dependencies.

Create libraries to separate interfaces, annotations and implementations. Often we can split a package into the libraries: api, module and interface.

  1. Add the directory to the MIGRATED_PROD_FILES of the module's root BUILD.bazel file

  2. Add the libraries to the list of deps dependencies in the targets that require the library

You will have to set the apropriate visbility. See the list of visibilities in the link below.

  1. Clean up any unused deps dependencies

  2. Verify that the app builds

Useful links

@fsharpasharp fsharpasharp changed the title Create a BUILD.bael file for domain/onboarding Create a BUILD.bazel file for domain/onboarding Jun 8, 2021
@jonathanalvares9009 jonathanalvares9009 self-assigned this Jun 15, 2021
@rishidyno
Copy link
Contributor

@JonathanAlvares if you are not working on this issue, @fsharpasharp can you assign me this issue.

@rt4914
Copy link
Contributor

rt4914 commented Nov 18, 2021

@rishidyno Un-assigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this.

@rishidyno rishidyno self-assigned this Nov 19, 2021
BenHenning pushed a commit that referenced this issue Dec 14, 2021
* create-bazel-file-for-onboarding

* removed-empty-deps

* changed-visibilities-and-library-names

* added-`testonly = True`-&-fixed-formatting

* added-test-deps-to-TEST_DEPS

* added-deps

* gave-meaningful-library-names

* formatted-code

* code-formatting

* code-format

* added-deps-and-code-format

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* added-more-dependencies

* changed retriever_prod_module name to retriever_test_module in onboarding testing build.bazel file

* added dependencies alphabetically 

added dependencies alphabetically

* sorted dependencies in order for lint test to pass

* nitfix

* added dependency

* Update BUILD.bazel

* changed ky_library_name from `retriever_module`
to `retriever_prod_module`
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Development

Successfully merging a pull request may close this issue.

6 participants