-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a BUILD.bazel file for domain/onboarding #3276
Labels
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
fsharpasharp
changed the title
Create a BUILD.bael file for domain/onboarding
Create a BUILD.bazel file for domain/onboarding
Jun 8, 2021
@JonathanAlvares if you are not working on this issue, @fsharpasharp can you assign me this issue. |
yash10019coder
assigned rishidyno and yash10019coder and unassigned rishidyno and yash10019coder
Aug 28, 2021
6 tasks
@rishidyno Un-assigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this. |
BenHenning
pushed a commit
that referenced
this issue
Dec 14, 2021
* create-bazel-file-for-onboarding * removed-empty-deps * changed-visibilities-and-library-names * added-`testonly = True`-&-fixed-formatting * added-test-deps-to-TEST_DEPS * added-deps * gave-meaningful-library-names * formatted-code * code-formatting * code-format * added-deps-and-code-format * Update BUILD.bazel * Update BUILD.bazel * Update BUILD.bazel * Update BUILD.bazel * added-more-dependencies * changed retriever_prod_module name to retriever_test_module in onboarding testing build.bazel file * added dependencies alphabetically added dependencies alphabetically * sorted dependencies in order for lint test to pass * nitfix * added dependency * Update BUILD.bazel * changed ky_library_name from `retriever_module` to `retriever_prod_module`
BenHenning
added
the
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
label
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This task is part of the build system migration from Gradle to Bazel.
Prerequesites
Task
domain/src/main/java/org/oppia/android/domain/onboarding/
and
domain/src/main/java/org/oppia/android/domain/onboarding/testing
Based on the imports in the Kotlin files, add the required third_party dependencies to make the libraries build. Check the Useful links section for a list of third_party dependencies. You may also need to add the non third_party dependencies.
Create libraries to separate interfaces, annotations and implementations. Often we can split a package into the libraries: api, module and interface.
Add the directory to the MIGRATED_PROD_FILES of the module's root BUILD.bazel file
Add the libraries to the list of deps dependencies in the targets that require the library
You will have to set the apropriate visbility. See the list of visibilities in the link below.
Clean up any unused deps dependencies
Verify that the app builds
Useful links
The text was updated successfully, but these errors were encountered: