Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] High-fi Onboarding Screens #3198

Closed
veena14cs opened this issue May 18, 2021 · 0 comments · Fixed by #3216
Closed

[RTL] High-fi Onboarding Screens #3198

veena14cs opened this issue May 18, 2021 · 0 comments · Fixed by #3216
Assignees
@veena14cs
Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

veena14cs commented May 18, 2021 •
edited
Loading

Onboading screens needs to support RTL.

  • The arrow icon needs to be reversed.
  • Skip button needs to be reversed.
  • The title text and sub-text needs to be reversed.

3
4
5
2
@veena14cs veena14cs added Type: Bug Priority: Essential This work item must be completed for its milestone. labels May 18, 2021
@veena14cs veena14cs changed the title [RTL] High-fi Onboarding navigation icon [RTL] High-fi Onboarding Screens May 18, 2021
@veena14cs veena14cs self-assigned this May 18, 2021
@veena14cs veena14cs added Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. and removed Type: Bug labels May 18, 2021
@veena14cs veena14cs mentioned this issue May 22, 2021
Merged
8 tasks
rt4914 pushed a commit that referenced this issue May 22, 2021
@veena14cs
Fix #3198: High-fi Rtl support Onboarding Screens. (#3216)
7ae2a3d 
* implemented recommendation system

* writing testcases

* Update TopicListControllerTest.kt

* reverted changes

* optimized list

* fixed recommended list

* fixed index error

* added timestamp for recently played

* removed walkthrough field

* writting testcases

* fixing testcase

* updated with develop

* Update TopicTestActivityForStory.kt

* fixed unrelated file changes

* Update ic_arrow_forward_black_24dp.xml

* Removed unwanted files.

* Remove unwanted files
@veena14cs veena14cs added this to the RTL Support milestone Jul 1, 2021
@veena14cs veena14cs removed the Priority: Essential This work item must be completed for its milestone. label Jul 6, 2021
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3198: High-fi Rtl support Onboarding Screens.
2 participants
@BenHenning @veena14cs