Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move project off of jcenter #2923

Closed
BenHenning opened this issue Mar 16, 2021 · 5 comments · Fixed by #3259
Closed

Move project off of jcenter #2923

BenHenning opened this issue Mar 16, 2021 · 5 comments · Fixed by #3259
Assignees
@BenHenning
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

See https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/. JCenter is turning down over the next 12 months. Most, if not all, of our packages should be available on other Maven repositories. This issue is tracking updating both Gradle & Bazel to:

  1. Remove our bintray/jcenter repository references
  2. Investigating all missing dependencies to find alternate repositories
  3. Updating Gradle/Bazel to use the new repositories in place of JCenter
  4. Ensure that the app builds with both Gradle & Bazel
@BenHenning
Copy link
Member Author

Relevant artifacts to help:

This was referenced Mar 16, 2021
Closed
Closed
@BenHenning BenHenning mentioned this issue Mar 20, 2021
Merged
8 tasks
@BenHenning BenHenning mentioned this issue May 6, 2021
Closed
@BenHenning
Copy link
Member Author

Per google/flexbox-layout#566 (comment) flexbox layout is now available on Google's Maven repository, so we should be able to migrate over to it.

@BenHenning BenHenning mentioned this issue May 25, 2021
Merged
@BenHenning
Copy link
Member Author

#3228 moved our pinview dependency over to Maven Central from JCenter/Bintray, and #3249 is doing the same for flexbox layout. I think after that one is done we will be able to remove JCenter/Bintray from our repository lists.

@BenHenning BenHenning self-assigned this May 25, 2021
BenHenning added a commit that referenced this issue May 26, 2021
@BenHenning
[RunAllTests] Fix #3217, part of #2923: migrate flexbox dependency to…
f87e504 
… pull from Google's Maven repository instead of JCenter/bintray (#3249)

* Update versions.bzl

Update flexbox to use the Google Maven dependency instead of JCenter.

* Update build.gradle

Update flexbox layout dependency to use Google Maven instead of JCenter.

* Update versions.bzl

FIx linter error.

* Update BUILD.bazel

Fix flexbox dependency reference since it's been updated.
@BenHenning BenHenning mentioned this issue May 27, 2021
Closed
@BenHenning
Copy link
Member Author

Another issue: https://github.com/sparrow007/CircularImageview is only available on jcenter. It looks like the dependency isn't really managed anymore, so I filed an issue #3258 to move to something that's maintained. We'll need to create a fork of the dependency and use jitpack to avoid jcenter.

That being said, Bazel builds without jcenter which is a bit confusing to me.

@BenHenning
Copy link
Member Author

Ah. Bazel builds because we already have a fork of the circular image view repo to support Bazel builds: https://github.com/oppia/CircularImageview.

@BenHenning BenHenning mentioned this issue May 27, 2021
Merged
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RunAllTests] Fix #2923: Remove direct bintray/jcenter dependence oppia/oppia-android
1 participant
@BenHenning