Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a BUILD.bazel file for the statusbar package in the utility module #2881

Closed
fsharpasharp opened this issue Mar 10, 2021 · 0 comments · Fixed by #2959
Closed

Create a BUILD.bazel file for the statusbar package in the utility module #2881

fsharpasharp opened this issue Mar 10, 2021 · 0 comments · Fixed by #2959
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@fsharpasharp
Copy link
Contributor

fsharpasharp commented Mar 10, 2021

This task is part of the build system migration from Gradle to Bazel.

Prerequesites

Task

  1. Create a BUILD.bazel file in

src/main/java/org/oppia/android/util/statusbar/

  1. Define the kt_android_library library

Based on the imports in the Kotlin files, add the required third_party dependencies to make the libraries build.

Run

bazel build :all

inside the directory, to verify that the libraries build.

Check the Useful links section for a list of third_party dependencies.

You can start with the following stub

load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_android_library")

kt_android_library(
    name = "status_bar_color",
    srcs = [
        "StatusBarColor.kt",
    ],
)
  1. Add the directory to the MIGRATED_PROD_FILES of the module's root BUILD.bazel file

  2. Add the libraries to the list of deps dependencies in the targets that require the library

You will have to set the apropriate visbility. See the list of visibilities in the link below.

  1. Clean up any unused deps dependencies

  2. Verify that the app builds

Useful links

@Arjupta Arjupta self-assigned this Mar 11, 2021
Arjupta added a commit to Arjupta/oppia-android that referenced this issue Mar 21, 2021
BenHenning pushed a commit that referenced this issue Apr 29, 2021
* Fixes #2881: Creating BUILD.bazel for statusbar utility

Fixes #2881 by creating a BUILD.bazel file

* Adding the path of statusbar in module level BUILD.bazel

* Failing lint check

* Taking the status bar utility directly to the app module

* suggested changes

* lint issue solved

* nit change
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants