-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final UI: Topic activity/fragment [Blocked: #15] #23
Comments
This is blocked on #15. |
@rt4914 can you clarify what remaining work needs to be done here? |
#140 animation is pending and also, @mschanteltc as discussed earlier, the icons in tabs are not looking good, we need updated icons/svgs mostly square in shape. |
I updated the icons so that they are all 24 px, meaning that some icons that are not equal in height and width have padding in the svg file. Does this resolve the issue? |
@mschanteltc Check this #505 (comment) |
* Icons updated * Updated train icon * Updated topic train icon * Final icon update
The topic page should provide background information on the topic, skills corresponding to the topic (which link to the concept card for that skill), navigation to training on skills in the topic, the progress of stories the user has played in that topic, and links to stories (with preference for in-progress/immediately upcoming stories, though all stories should be viewable). See the PRD for specifics.
Note that this is tracking implementing the final UI for just the topic page. The final UIs for each constituent tab is indicated as a blocker of this issue.
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-
Task Items
Final check on all fragments and final touch-up
Accessibility Scanner is working correctly (https://support.google.com/accessibility/android/answer/6376570?hl=en)
The text was updated successfully, but these errors were encountered: