Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final UI: Topic activity/fragment [Blocked: #15] #23

Closed
4 tasks
BenHenning opened this issue Aug 2, 2019 · 6 comments
Closed
4 tasks

Final UI: Topic activity/fragment [Blocked: #15] #23

BenHenning opened this issue Aug 2, 2019 · 6 comments
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019

The topic page should provide background information on the topic, skills corresponding to the topic (which link to the concept card for that skill), navigation to training on skills in the topic, the progress of stories the user has played in that topic, and links to stories (with preference for in-progress/immediately upcoming stories, though all stories should be viewable). See the PRD for specifics.

Note that this is tracking implementing the final UI for just the topic page. The final UIs for each constituent tab is indicated as a blocker of this issue.

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-

Task Items

  • Hamburger Icon and Toolbar/ActionBar title

Screenshot 2019-11-05 at 9 26 38 PM

  • TabLayout with icons and titles

Screenshot 2019-11-05 at 9 26 45 PM

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #15.

@BenHenning BenHenning changed the title Topic page Topic page [Blocked: #15] Aug 12, 2019
@BenHenning BenHenning changed the title Topic page [Blocked: #15] Final UI: Topic page [Blocked: #15] Sep 19, 2019
@BenHenning BenHenning changed the title Final UI: Topic page [Blocked: #15] Final UI: Topic activity/fragment [Blocked: #15] Sep 19, 2019
nikitamarysolomanpvt added a commit that referenced this issue Nov 14, 2019
* topic tab hi-fi UI

* nit

* nit

* nit

* nit

* nit

* nit

* nit
@BenHenning
Copy link
Member Author

@rt4914 can you clarify what remaining work needs to be done here?

@rt4914
Copy link
Contributor

rt4914 commented Dec 2, 2019

#140 animation is pending and also, @mschanteltc as discussed earlier, the icons in tabs are not looking good, we need updated icons/svgs mostly square in shape.
Screenshot 2019-12-02 at 11 57 30 PM

@mschanteltc
Copy link

mschanteltc commented Dec 2, 2019

I updated the icons so that they are all 24 px, meaning that some icons that are not equal in height and width have padding in the svg file. Does this resolve the issue?

@rt4914
Copy link
Contributor

rt4914 commented Dec 2, 2019

I updated the icons so that they are all 24 px, meaning that some icons that are not equal in height and width have padding in the svg file. Does this resolve the issue?

@mschanteltc Check this #505 (comment)

rt4914 added a commit that referenced this issue Dec 3, 2019
* Icons updated

* Updated train icon

* Updated topic train icon

* Final icon update
veena14cs added a commit that referenced this issue Apr 20, 2020
* fixed high fi

* fixed accessibility test

* Update topic_lessons_fragment.xml
@rt4914
Copy link
Contributor

rt4914 commented Jun 24, 2020

This issue can be closed as it has been fixed via #995 & #505

@rt4914 rt4914 closed this as completed Jun 24, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

4 participants