Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test FractionInputHasNoFractionalPartRuleClassifier #1886

Closed
Sarthak2601 opened this issue Sep 24, 2020 · 0 comments · Fixed by #1932
Closed

Thoroughly test FractionInputHasNoFractionalPartRuleClassifier #1886

Sarthak2601 opened this issue Sep 24, 2020 · 0 comments · Fixed by #1932
Assignees
@prayutsu
Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 24, 2020 •
edited by rt4914
Loading

Since the FractionInputHasNoFractionalPartRuleClassifier was copied from Oppia web, it didn't have corresponding tests added to verify correctness. These should be ported over from Oppia web as well to ensure that each classifier has working functionality.

Useful reference - https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. good first issue This item is good for new contributors to make their pull request. labels Sep 24, 2020
@Sarthak2601 Sarthak2601 added this to the Backlog milestone Sep 24, 2020
@Sarthak2601 Sarthak2601 mentioned this issue Sep 24, 2020
Closed
29 tasks
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@prayutsu prayutsu mentioned this issue Oct 5, 2020
Merged
8 tasks
MohamedMedhat1998 pushed a commit that referenced this issue Oct 6, 2020
@prayutsu
Fix #1886 : Add tests for FractionInputHasNoFractionalPartRuleClassif…
d7fcac6 
…ierProvider (#1932)

* add basic tests

* tried fixing error

* added tests for FractionInputHasNoFractionalPartRuleClassifierProvider

* fixed reviewed changes

* fixed lint
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prayutsu prayutsu

Labels
good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
3 participants
@BenHenning @Sarthak2601 @prayutsu