Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading text size not scrollable or flexible #1802

Closed
anandwana001 opened this issue Sep 4, 2020 · 2 comments · Fixed by #1819
Closed

Reading text size not scrollable or flexible #1802

anandwana001 opened this issue Sep 4, 2020 · 2 comments · Fixed by #1819
Assignees
@prayutsu
Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

anandwana001 commented Sep 4, 2020 •
edited
Loading

Describe the bug
Reading Text Size screen not fitting the flexible text

To Reproduce
Steps to reproduce the behavior:

  1. Open reading text size screen from options
  2. Change text size and see the text size changing above

Expected behavior
The complete text should be visible

Mock link - https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/2eaf085a-c2a7-4b1d-b515-5b32f8642669/specs/

Screenshots
Screenshot_2020-09-04-19-03-03-426_org oppia app

Device

  • Device/emulator being used
  • SDK version

Additional context
Add any other context about the problem here.
@anandwana001 anandwana001 changed the title Reading text size scrollable or flexible Reading text size not scrollable or flexible Sep 4, 2020
@anandwana001
Copy link
Contributor Author

@prayutsu would you like to work on this?

@anandwana001 anandwana001 added the good first issue This item is good for new contributors to make their pull request. label Sep 7, 2020
@prayutsu
Copy link
Contributor

prayutsu commented Sep 7, 2020

@prayutsu would you like to work on this?

Definitely

@prayutsu prayutsu mentioned this issue Sep 7, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Sep 10, 2020
@prayutsu
Fix #1802 : Reading text size not scrollable or flexible (#1819)
38ea344 
* Fixed Reading textSize to display the actual size of the text

* fixed errors

* Fixed mistaken changes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prayutsu prayutsu

Labels
good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1802 : Reading text size not scrollable or flexible prayutsu/oppia-android
3 participants
@BenHenning @anandwana001 @prayutsu