Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get HW info from DMI/SMBIOS #125

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Get HW info from DMI/SMBIOS #125

merged 2 commits into from
Nov 18, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Nov 17, 2022

Fixes #124

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb requested a review from alknopfler November 17, 2022 16:21
@glimchb glimchb force-pushed the main branch 2 times, most recently from d7ee064 to a3fba5c Compare November 17, 2022 16:32
@glimchb glimchb changed the title Get HW info from DMI/SMBIOD Get HW info from DMI/SMBIOS Nov 17, 2022
Fixes opiproject#124

Signed-off-by: Boris Glimcher <[email protected]>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #125 (efe9a1e) into main (c5f76a3) will decrease coverage by 0.36%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   79.02%   78.66%   -0.37%     
==========================================
  Files          12       12              
  Lines         596      600       +4     
==========================================
+ Hits          471      472       +1     
- Misses        106      107       +1     
- Partials       19       21       +2     
Impacted Files Coverage Δ
sztp-agent/pkg/secureagent/utils.go 88.23% <62.50%> (-3.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb glimchb marked this pull request as ready for review November 17, 2022 21:02
@glimchb glimchb requested a review from a team as a code owner November 17, 2022 21:02
Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glimchb glimchb merged commit 0c2b064 into opiproject:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use ghw to get board and product inventory info for the agent
2 participants