Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: reduce images size #51

Merged
merged 2 commits into from
Jan 6, 2023
Merged

docker: reduce images size #51

merged 2 commits into from
Jan 6, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Jan 6, 2023

By introducing multi-stage build
And switching to alpine
And using grpcurl from docker

x20 size reduction !

$ docker images | grep marvell
opi-marvell-bridge                      main           fe68a9af4097   2 minutes ago    74.2MB
ghcr.io/opiproject/opi-marvell-bridge   main           6211712b57b3   23 hours ago     1.72GB

Signed-off-by: Boris Glimcher [email protected]

By introducing multi-stage build
And switching to alpine
And using grpcurl from docker

x20 size reduction !

```
$ docker images | grep marvell
opi-marvell-bridge                      main           fe68a9af4097   2 minutes ago    74.2MB
ghcr.io/opiproject/opi-marvell-bridge   main           6211712b57b3   23 hours ago     1.72GB
```

Signed-off-by: Boris Glimcher <[email protected]>
cosmetic align to other repos

Signed-off-by: Boris Glimcher <[email protected]>
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #51 (9fe5467) into main (813c22a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files           3        3           
  Lines         660      660           
=======================================
  Hits          535      535           
  Misses        103      103           
  Partials       22       22           
Impacted Files Coverage Δ
main.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glimchb glimchb marked this pull request as ready for review January 6, 2023 19:27
@glimchb glimchb requested a review from a team as a code owner January 6, 2023 19:27
@glimchb
Copy link
Member Author

glimchb commented Jan 6, 2023

@glimchb glimchb requested a review from mkalderon January 6, 2023 19:28
.github/workflows/linters.yml Show resolved Hide resolved
@glimchb glimchb merged commit 585e0ae into main Jan 6, 2023
@glimchb glimchb deleted the tests branch January 6, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants