Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ospf): cleanup the linting errors #465

Merged
merged 9 commits into from
Aug 8, 2024
Merged

feat(ospf): cleanup the linting errors #465

merged 9 commits into from
Aug 8, 2024

Commits on Aug 8, 2024

  1. feat(ospf): fix lint errors for --disable-rule=core::0123 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    93c694c View commit details
    Browse the repository at this point in the history

  2. feat(ospf): fix lint errors for --disable-rule=core::0131 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2e4bd3a View commit details
    Browse the repository at this point in the history

  3. feat(ospf): fix lint errors for --disable-rule=core::0132 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b4be36a View commit details
    Browse the repository at this point in the history

  4. feat(ospf): fix lint errors for --disable-rule=core::0133 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2b2026d View commit details
    Browse the repository at this point in the history

  5. feat(ospf): fix lint errors for --disable-rule=core::0191 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    17f7219 View commit details
    Browse the repository at this point in the history

  6. feat(ospf): fix lint errors for --disable-rule=core::0203 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ac28f61 View commit details
    Browse the repository at this point in the history

  7. feat(ospf): fix lint errors for --disable-rule=core::0216 

    Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ea62ae2 View commit details
    Browse the repository at this point in the history

  8. feat(ospf): fix lint errors for --disable-rule=client-libraries::4232… 

    …::required-fields

Clean up lint errors when option is removed.

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1239e12 View commit details
    Browse the repository at this point in the history

  9. feat(ospf): cleanup the linting errors 

    Fix up the lint errors after changing the Makefile to remove
the options to disable the linting errors. The Makefile change
is not committed in this PR request to allow the rest of the
protobuf files to build until all protobuf files are updated.

Fixed and updated the two files bgp.proto and cloudrpc.proto files
to address the follow lint error types. Also the generated files
are included in this PR.

    --disable-rule=core::0123
    --disable-rule=core::0131
    --disable-rule=core::0132
    --disable-rule=core::0133
    --disable-rule=core::0134
    --disable-rule=core::0140
    --disable-rule=core::0156
    --disable-rule=core::0158
    --disable-rule=core::0191
    --disable-rule=core::0192
    --disable-rule=core::0203
    --disable-rule=core::0216
    --disable-rule=client-libraries::4232::required-fields

Signed-off-by: Keith Wiles <[email protected]>
    @KeithWiles
    KeithWiles committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6a22970 View commit details
    Browse the repository at this point in the history