Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable activities pending specs, address flakiness #17197

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Nov 13, 2024

@akabiru akabiru changed the title Enable activities spec, address flakiness Enable activities pending specs, address flakiness Nov 13, 2024
Else the following error can be raised: *_when running within docker containers_

```
 Work package activity notification bubble when admin is visiting the work package removes the notification bubble after the comment is read
     Failure/Error: visit path

     Ferrum::PendingConnectionsError:
       Request to http://backend-test:3000/projects/myproject_no_29/work_packages/214/activity reached server, but there are still pending connections: http://backend-test:3000/api/v3/users/586/avatar, http://backend-test:3000/api/v3/users/587/avatar, http://backend-test:3000/api/v3/users/588/avatar
```
@akabiru akabiru self-assigned this Nov 13, 2024
@aaron-contreras
Copy link
Contributor

aaron-contreras commented Nov 13, 2024

Would something like this be helpful? You can set the polling interval to 1 second and this guarantees that RSpec waits are longer than the time it takes the poll to happen. Would make it simpler to deal with the flakiness

RSpec.describe "boards onboarding tour",
               :js,
               with_settings: { notifications_polling_interval: 1_000 } do

@akabiru
Copy link
Member Author

akabiru commented Nov 13, 2024

Would something like this be helpful? You can set the polling interval to 1 second and this guarantees that RSpec waits are longer than the time it takes the poll to happen. Would make it simpler to deal with the flakiness

RSpec.describe "boards onboarding tour",
               :js,
               with_settings: { notifications_polling_interval: 1_000 } do

Cheers for checking in @aaron-contreras - it's slightly different as the new "activities tab polling" is separate from the "old" notifications polling interval. At present, the activities tab polling interval is hardcoded to 10s but can be changed in test env via WORK_PACKAGES_ACTIVITIES_TAB_POLLING_INTERVAL_IN_MS - albeit not the most fitting approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants