Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[55181] Replace sidemenu of notification center with Rails component #16040

Merged
merged 12 commits into from
Jul 11, 2024
Merged

[55181] Replace sidemenu of notification center with Rails component #16040

merged 12 commits into from
Jul 11, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jul 4, 2024 •
edited
Loading

This extracts the menu logic from #15840 and aims to replace the last occurence of an agular submenu with the rails Submenu component.

  • Use Common::SubmenuComponent to render the submenu of the notifications module
    • Extend the component to deal with icons and counts
      • Use Octicons instead of old icon font ?
    • Automatically update when a notification is marked as read
    • Move the star next to the title, but the count at the end of the row
    • Show an EE icon for EE queries
  • Follow the same code structure we introduced recently for the other modules
  • Remove op-sidemenu, component see https://community.openproject.org/projects/openproject/work_packages/55900/activity
  • Merge sidemenu.sass vs sidebar.sass into one new submenu.sass and harmonize the selectors
  • Get tests green

https://community.openproject.org/projects/openproject/work_packages/55181/activity

@HDinger HDinger added the feature label Jul 4, 2024
@HDinger HDinger added this to the 14.4.x milestone Jul 4, 2024
@HDinger HDinger force-pushed the implementation/55181-replace-sidemenu-of-notification-center-with-rails-component branch 11 times, most recently from 40a7ff0 to 9c4984c Compare July 11, 2024 11:16
@HDinger HDinger marked this pull request as ready for review July 11, 2024 11:27
HDinger and others added 12 commits July 11, 2024 15:29
@HDinger
First draft of rails-based submenu for notifications center
2a9aa95 
* Show counts from actual query

* Add group by project

* Remove menu component

* Reload menu frame when marking notification as read

Co-authored-by: Oliver Günther <[email protected]>
@HDinger
Adapt structure of notifications sidemenu to the same we have in othe…
d7fe552 
…r modules
@HDinger
Remove obsolete angular sidemenu component
421c12f
@HDinger
Change route definition for the notifications menu and the center its…
7e1b883 
…elf so that the center path remains unchanged in comparision to before. Otherwise, we'd have to replace all occurences of the path
@HDinger
Extend base Submenu class to deal with count and icons
13a6a77
@HDinger
Adapt tests to new rails based submenu of notification center
b118b10
@HDinger
Show total amount of notifications next to "inbox" and fix date alert…
c9caa58 
… filter
@HDinger
Indicate project hierarchy in the notification sidebar && fix some mi…
d3fc67a 
…nor translation issues
@HDinger
Show EE upsale icons in EE queries of the submenu
2a0577b
@HDinger
Use Octicons in submenu
3056387
@HDinger
Merge obsolete "sidebar.sass" and "sidemenu.sass" files into one new …
896dd8e 
…"submenu_component.sass" and harmonize the selectors
@HDinger
Please rubocop and reduce abc
e5c7eac
@HDinger HDinger force-pushed the implementation/55181-replace-sidemenu-of-notification-center-with-rails-component branch from 11e2f1c to e5c7eac Compare July 11, 2024 13:29
@oliverguenther oliverguenther merged commit 75206e9 into dev Jul 11, 2024
11 checks passed
@oliverguenther oliverguenther deleted the implementation/55181-replace-sidemenu-of-notification-center-with-rails-component branch July 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
feature
Milestone
14.4.x
2 participants
@HDinger @oliverguenther