[#55939] OneDrive/SharePoint storage with AMPF can be added as manual folder #16007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judithroth
commented
Jul 1, 2024
| @@ -0,0 +1,30 @@ | |||
| module OAuthConnectionsHelpers | |||
| def mock_one_drive_authorization_validation(with: {}) | |||
There was a problem hiding this comment.
If someone has a better suggestion on how to name this method please let me know 🙂
There was a problem hiding this comment.
eventually this will vanish for a VCR cassette, so I wouldn't bother too much. Name is fine.
There was a problem hiding this comment.
Actuall I tried using a VCR cassette first (it "shows no option for manually managed permissions", vcr: "auth/one_drive/user_token" do) but had some issues with it, because it's a feature spec:
An HTTP request has been made that VCR does not know how to handle:
GET http://172.18.0.9:3000/__identify__
(The IP is from the docker container and probably needs to be ignored by VCR - I didn't dive into this).
judithroth
force-pushed
the
bug/55939-onedrivesharepoint-storage-with-ampf-can-be-added-as-manual-folder
branch
2 times, most recently
from
e851245
to
c70ad6a
Compare
judithroth
force-pushed
the
bug/55939-onedrivesharepoint-storage-with-ampf-can-be-added-as-manual-folder
branch
from
c70ad6a
to
1858a34
Compare
…as manual folder https://community.openproject.org/work_packages/55939 Because managing of permissions is complex on OneDrive, a storage with automatically managed access and folders can not host projects with manually managed permissions. --- Please notice that an existing file had to be renamed due to rubocop complaining.
judithroth
force-pushed
the
bug/55939-onedrivesharepoint-storage-with-ampf-can-be-added-as-manual-folder
branch
from
1858a34
to
3248469
Compare
Kharonus
requested changes
Jul 9, 2024
modules/storages/spec/contracts/storages/project_storages/base_contract_spec.rb
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,30 @@ | |||
| module OAuthConnectionsHelpers | |||
| def mock_one_drive_authorization_validation(with: {}) | |||
There was a problem hiding this comment.
eventually this will vanish for a VCR cassette, so I wouldn't bother too much. Name is fine.
judithroth
deleted the
bug/55939-onedrivesharepoint-storage-with-ampf-can-be-added-as-manual-folder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/55939
Because managing of permissions is complex on OneDrive, a storage with automatically managed access and folders can not host projects with manually managed permissions.
Please notice that an existing file had to be renamed due to rubocop complaining.