Set host for default_url_options #15963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
2 times, most recently
from
641b12a
to
e677daf
Compare
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
2 times, most recently
from
9b6f524
to
cd0c1f1
Compare
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
2 times, most recently
from
2f62aac
to
b2f8fcb
Compare
oliverguenther
changed the title
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
7 times, most recently
from
432c64a
to
80ee601
Compare
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
from
80ee601
to
0d67d6b
Compare
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
2 times, most recently
from
478a243
to
4ccfcac
Compare
oliverguenther
commented
Jul 8, 2024
This results in us having to use a bit more helpers around request and feature specs to ensure that the configured host name also matches the requested one.
we can no longer manipulate the host name in a feature spec
oliverguenther
force-pushed
the
fix/set-header-before-action
branch
from
4ccfcac
to
aec7df1
Compare
2 tasks
dombesz
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenProject manages its own host name setting, most often coming from either the packaged installation or an explicit ENV variable, we do not need to trust the HOST header to create our links. Instead, always use the host_name setting.
https://community.openproject.org/work_packages/55937