Hide children section for milestones #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbliard
requested changes
Jun 24, 2024
There was a problem hiding this comment.
I have only reviewed behavior and not the code yet.
It works properly in these scenarios:
- Selecting a milestone wp and going to relations tab, the children section is not visible
- Changing a wp type from milestone to task, the children section becomes visible
It does not work properly in these scenarios:
- Going to a Task wp, the children section of the relations is not visible. It should be visible.
- Initially I saw it while reloading but it seems to alway be hidden as it also happens when navigating from a wp list view.
- Changing wp type from Milestone to Task shows the children section, but then changing it to Milestone again does not hide it. It should become hidden.
That's probably why some tests are failing.
oliverguenther
force-pushed
the
fix/milestone-children-section
branch
2 times, most recently
from
59f6fa6
to
8845f0b
Compare
oliverguenther
force-pushed
the
fix/milestone-children-section
branch
from
8845f0b
to
83ca940
Compare
oliverguenther
force-pushed
the
fix/milestone-children-section
branch
from
83ca940
to
3787730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/54983