[WIP] Reorganizes the StorageInteraction code plus other improvements #15841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mereghost
commented
Jun 13, 2024
| module Commands | ||
| class CopyTemplateFolder | ||
| using Peripherals::ServiceResultRefinements | ||
| Util = Peripherals::StorageInteraction::Nextcloud::Util |
There was a problem hiding this comment.
This would eventually be removed when Util gets moved (and maybe split) into support
mereghost
commented
Jun 13, 2024
| module Storages | ||
| module Adapters | ||
| module Nextcloud | ||
| class ManagedFolderIdentifier |
There was a problem hiding this comment.
This isn't exactly support (as in supporting code) but represents a concept that is storage dependent.
Should it go under a special namespace?
mereghost
commented
Jun 13, 2024
| module Nextcloud | ||
| module Queries | ||
| class Files | ||
| Auth = Peripherals::StorageInteraction::Authentication |
There was a problem hiding this comment.
Authentication will probably live under Adapters::Support::Authentication
mereghost
commented
Jun 13, 2024
| @@ -37,7 +37,7 @@ module Peripherals | |||
| register(:file_ids, StorageInteraction::Nextcloud::FileIdsQuery) | |||
| register(:file_info, StorageInteraction::Nextcloud::FileInfoQuery) | |||
| register(:files_info, StorageInteraction::Nextcloud::FilesInfoQuery) | |||
| register(:files, StorageInteraction::Nextcloud::FilesQuery) | |||
| register(:files, Adapters::Nextcloud::Queries::Files) | |||
There was a problem hiding this comment.
Registries should be moved to their adapter folders (maybe we could add a way to auto-register? 🤔)
mereghost
force-pushed
the
maint/storage-module-structure
branch
2 times, most recently
from
84a7096
to
bef03d0
Compare
mereghost
force-pushed
the
maint/storage-module-structure
branch
4 times, most recently
from
9a613fa
to
b42de07
Compare
mereghost
force-pushed
the
maint/storage-module-structure
branch
from
b42de07
to
986ec11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS AN EXPERIMENT
What?
We have a bunch of namespaces under
Storagesbut some don't bring much clarity on what is their intended purpose or we gained new insight on the necessities for different service providers.Why?
All storage supporting code lives under
Peripherals(under thecommon/storages/folder) and has become kind of that practical drawer where you just throw anything you wanna "hide" (under the guise of organizing) and it is slowing becoming a mess.How?
First I'm introducing the Adapters namespace (under
common/storage/adapters) where the code that is tailored goes (adapters/nextcloud,adapters/one_drive).Each adapter structure is identical (in an ideal world) with the following namespaces / folders:
StoragemodelsThe Adapters namespace will also have supporting code to it - Authentication Strategies, Specific Errors and also Objects defining the shape the results (success/failure) for all the required
CommandsandQueries.The
adaptersfolder/namespace also houses all the pieces used by the adapters (authentication, value objects etc)