Merge pull request #48 from opf/feature/new-icons-for-xeokit-viewer-t…

…oolbar Add new icons for xeokit toolbar
opf · Apr 17, 2024 · 2d5a963 · 2d5a963
2 parents 0069146 + 3125011
commit 2d5a963
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 0 deletions.
diff --git a/.changeset/poor-ears-begin.md b/.changeset/poor-ears-begin.md
@@ -0,0 +1,5 @@
+---
+'@openproject/octicons': minor
+---
+
+Add icons for xeokit toolbar
diff --git a/.gitignore b/.gitignore
@@ -8,6 +8,9 @@ node_modules
 vendor
 Gemfile.lock
 
+# Jetbrains IDE
+.idea/
+
 # Ignore build/export artifacts
 lib/**/build/
 

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -37,6 +37,11 @@ git checkout -b <branch-name>
 
 ### 3. Add or update SVG files in the `/icons` directory
 
+Be sure to add SVG files with the correct naming (suffix `-16` required,
+suffixes `-12` and `-24` are optional). Check for the correct viewBox
+inside the SVG, but do not bother with `fill`, `fill-rule`, or `clip-rule`
+attributes, as those are removed by the CI step "Optimize SVGs".
+
 ### 4. Add or update keywords in `keywords.json`
 
 ```diff

diff --git a/icons/op-cursor-rectangle-select-16.svg b/icons/op-cursor-rectangle-select-16.svg
diff --git a/icons/op-cursor-select-16.svg b/icons/op-cursor-select-16.svg
diff --git a/icons/op-erase-16.svg b/icons/op-erase-16.svg
diff --git a/icons/op-scissors-16.svg b/icons/op-scissors-16.svg
diff --git a/keywords.json b/keywords.json
@@ -145,6 +145,10 @@
   "north-star": ["star", "snowflake", "asterisk"],
   "note": ["card", "paper", "ticket"],
   "octoface": ["octocat", "brand"],
+  "op-cursor-rectangle-select": ["group", "select"],
+  "op-cursor-select": ["pointer", "select", "mouse"],
+  "op-erase": ["remove", "delete"],
+  "op-scissors": ["cut", "snip", "slice", "clip"],
   "organization": ["people", "group", "team"],
   "package": ["box", "ship"],
   "paintcan": ["style", "theme", "art", "color"],