Implement initial list timeentries command #7
Conversation
| User FilterOption = iota | ||
| ) | ||
|
|
||
| func UserFilter(name string) requests.Filter { |
There was a problem hiding this comment.
🟡 I'd love to extend this filter to the - admittedly not everywhere used - filter interface. This one is used only in the work package resource, and I planned to rewrite every filter to it. So, it'd be nice to have this new filter already taking the desired form.
There was a problem hiding this comment.
I can imagine that there are some confusions :D especially as the code is half implemented around the filters. So, we can pair on it, if you want.
|
|
||
| func All() ([]*models.TimeEntry, error) { | ||
| var filters []requests.Filter | ||
| filters = append(filters, UserFilter("me")) |
There was a problem hiding this comment.
🟡 I understand that you want to fetch only the time entries assigned to me on a default fetch. That makes sense, but the logic for that should be in the command, not in the read function IMHO. this also gets easier, if the filter is using the "new and shiny" implementation.
myabc
force-pushed
the
feature/time-entries
branch
from
1cd9a3e to
b5ab3d9
Compare
An initial patch to support listing (personal) time entries. I wrote this to "scratch an itch" - and make my own time tracking easier.
Obviously full CRUD would be nice, but this is just a start.
Also, since this is the first go code I've written, please forgive if it not idiomatic!