-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add PSA compliance #539
feat: add PSA compliance #539
Conversation
|
We should also document somewhere that this change will require bundle image contents to be readable by the unpack pod, which may have an unpredictable process UID. In general, we can probably say bundle files and directories should have GID=0 and they should have permissions 0750 and 0640 at a minimum. |
@joelanford Is this a potential non-starter for things like the |
Signed-off-by: Tyler Slaton <tyslaton@redhat.com> Co-authored-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
f93a361 to
c776a86
Compare
|
@tylerslaton, maybe that'll dictate that the registry provisioner runs in a separate namespace with less restrictive PSA (e.g. baseline)? |
3ac6822 to
4e72c36
Compare
416a77d to
978b694
Compare
|
As a follow-up, can we:
"And helm?" because I'm not sure what sort of file permissions Helm OCI images have. |
joelanford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit about adding a TODO comment. Otherwise LGTM.
978b694 to
d7a877e
Compare
d7a877e to
1c36f0c
Compare
Signed-off-by: Tyler Slaton <tyslaton@redhat.com> Co-authored-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
1c36f0c to
535ea0a
Compare
anik120
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tylerslaton I have a couple of clarifying questions otherwise looks good for the most part 🚀
Summary
This PR brings Pod Security Admission (PSA) standards to RukPak in the form of updating the Namespace manifest (in accordance with the Kubernetes documentation) and Deployments.