Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add docker context to buildx command #6224

Closed
wants to merge 1 commit into from
Closed

scripts: add docker context to buildx command #6224

wants to merge 1 commit into from

Conversation

gmtstephane
Copy link

This PR Closes #6223

Description of the change:
Fix make docker-buildx command by adding the temporary Dockerfile.cross context location

Motivation for the change:

Make docker-buildx works again

@everettraven
Copy link
Contributor

@gmtstephane Thanks for this contribution!

One thing I noticed is that you are making changes to the operators we have scaffolded in our testdata directory. While this is an important step in the overall flow of resolving this issue, it unfortunately does not fix the root of the problem which is that this command is scaffolded in the Makefile by the go plugin which is maintained as part of the Kubebuilder project.

Taking a look at the Kubebuilder project, it seems this has already been fixed by kubernetes-sigs/kubebuilder#3046 and therefore we just need to update our Kubebuilder dependency in the go.mod file.

After the dependency is updated, running make generate should regenerate our testdata.

@gmtstephane
Copy link
Author

@everettraven Thanks for the response.

I can confirm that updating kubebuilder fixed the problem for me
Maybe this fixed version should come as default in the go.mod ?

@everettraven
Copy link
Contributor

everettraven commented Dec 20, 2022

Maybe this fixed version should come as default in the go.mod ?

@gmtstephane Yep, eventually we will update the dependencies that are built and shipped with the Operator SDK binary and this should be picked up. I think this should be sooner rather than later, but I am just returning from vacation and am not sure if it has already been discussed by other maintainers what the timeline for updating the version of our Kubebuilder dependency is.

@jmrodri
Copy link
Member

jmrodri commented Jan 10, 2023

@gmtstephane can you please sign your commits? It's failing the DCO check.

@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:53 — with GitHub Actions Inactive
@gmtstephane gmtstephane temporarily deployed to deploy January 10, 2023 19:54 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor

@gmtstephane I am actually going to close this PR since the proper resolution of this issue is to update our Kubebuilder dependency version to one that contains this fix. Thanks for taking the time to make this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang operator docker buildx command : missing context path
3 participants